Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 2012393002: Leak detector posts notifications to task runner (Closed)

Created:
4 years, 6 months ago by Simon Que
Modified:
4 years, 6 months ago
CC:
chromium-reviews, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org, asvitkine+watch_chromium.org, Will Harris
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Leak detector posts notifications to task runner Instead of posting to the browser process' UI thread, pass in a generic TaskRunner and post the notifications to it. On the browser process, pass in the TaskRunner for the browser process' UI thread. On other processes, a different TaskRunner can be passed in. BUG=chromium:615223 TEST=unit tests pass R=asvitkine@chromium.org, primiano@chromium.org Committed: https://crrev.com/685b914a3f55fe47863648086e3f4bedd4188814 Cr-Commit-Position: refs/heads/master@{#396560}

Patch Set 1 #

Patch Set 2 : Rebased; include base/location.h #

Total comments: 2

Patch Set 3 : CHECK -> EXPECT_TRUE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -16 lines) Patch
M chrome/browser/metrics/leak_detector_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/metrics/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/metrics/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/metrics/leak_detector/leak_detector.h View 4 chunks +15 lines, -5 lines 0 comments Download
M components/metrics/leak_detector/leak_detector.cc View 1 4 chunks +9 lines, -7 lines 0 comments Download
M components/metrics/leak_detector/leak_detector_unittest.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Simon Que
4 years, 6 months ago (2016-05-26 21:52:32 UTC) #1
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/2012393002/diff/20001/components/metrics/leak_detector/leak_detector_unittest.cc File components/metrics/leak_detector/leak_detector_unittest.cc (right): https://codereview.chromium.org/2012393002/diff/20001/components/metrics/leak_detector/leak_detector_unittest.cc#newcode79 components/metrics/leak_detector/leak_detector_unittest.cc:79: CHECK(base::ThreadTaskRunnerHandle::IsSet()); Nit: Since this is a test, use ...
4 years, 6 months ago (2016-05-27 13:58:22 UTC) #2
Primiano Tucci (use gerrit)
LGTM % asvitkine@ comment
4 years, 6 months ago (2016-05-27 16:05:41 UTC) #3
Simon Que
https://codereview.chromium.org/2012393002/diff/20001/components/metrics/leak_detector/leak_detector_unittest.cc File components/metrics/leak_detector/leak_detector_unittest.cc (right): https://codereview.chromium.org/2012393002/diff/20001/components/metrics/leak_detector/leak_detector_unittest.cc#newcode79 components/metrics/leak_detector/leak_detector_unittest.cc:79: CHECK(base::ThreadTaskRunnerHandle::IsSet()); On 2016/05/27 13:58:22, Alexei Svitkine (slow) wrote: > ...
4 years, 6 months ago (2016-05-27 18:26:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012393002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012393002/40001
4 years, 6 months ago (2016-05-27 18:29:05 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-05-27 21:13:44 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 21:15:19 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/685b914a3f55fe47863648086e3f4bedd4188814
Cr-Commit-Position: refs/heads/master@{#396560}

Powered by Google App Engine
This is Rietveld 408576698