Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2012333002: Make the object store visible in Observatory. (Closed)

Created:
4 years, 6 months ago by rmacnak
Modified:
4 years, 6 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -89 lines) Patch
M runtime/observatory/lib/elements.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/elements.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/application.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 1 1 chunk +18 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_view.html View 1 1 chunk +6 lines, -0 lines 0 comments Download
A + runtime/observatory/lib/src/elements/objectstore_view.dart View 1 2 1 chunk +10 lines, -7 lines 0 comments Download
A runtime/observatory/lib/src/elements/objectstore_view.html View 1 chunk +46 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 chunks +38 lines, -0 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/object_store.h View 1 1 chunk +90 lines, -82 lines 0 comments Download
M runtime/vm/object_store.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download
M runtime/vm/service.cc View 1 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rmacnak
4 years, 6 months ago (2016-05-26 20:16:55 UTC) #2
turnidge
Ryan and I discussed this offline and came up with a plan where there will ...
4 years, 6 months ago (2016-05-31 18:08:07 UTC) #3
rmacnak
Updated to use a _getObjectStore RPC instead of a field in the Isolate response.
4 years, 6 months ago (2016-05-31 21:10:32 UTC) #5
turnidge
lgtm w/ one comment https://codereview.chromium.org/2012333002/diff/20001/runtime/observatory/lib/src/elements/objectstore_view.dart File runtime/observatory/lib/src/elements/objectstore_view.dart (right): https://codereview.chromium.org/2012333002/diff/20001/runtime/observatory/lib/src/elements/objectstore_view.dart#newcode20 runtime/observatory/lib/src/elements/objectstore_view.dart:20: return objectStore.reload(); As discussed offline, ...
4 years, 6 months ago (2016-06-01 18:06:22 UTC) #6
rmacnak
https://codereview.chromium.org/2012333002/diff/20001/runtime/observatory/lib/src/elements/objectstore_view.dart File runtime/observatory/lib/src/elements/objectstore_view.dart (right): https://codereview.chromium.org/2012333002/diff/20001/runtime/observatory/lib/src/elements/objectstore_view.dart#newcode20 runtime/observatory/lib/src/elements/objectstore_view.dart:20: return objectStore.reload(); On 2016/06/01 18:06:22, turnidge wrote: > As ...
4 years, 6 months ago (2016-06-01 19:58:46 UTC) #7
rmacnak
4 years, 6 months ago (2016-06-01 20:00:28 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
435b371cb799634733896abb301b6a27ae2458f8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698