build/android/pylib/local/device/local_device_test_run.py - Issue 2012323002: [Android] Implement perf tests to platform mode.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/pylib/local/device/local_device_test_run.py

Issue 2012323002: [Android] Implement perf tests to platform mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: do not run as default and rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« build/android/pylib/local/device/local_device_perf_test_run.py ('K') | « build/android/pylib/local/device/local_device_perf_test_run.py ('k') | build/android/pylib/perf/perf_test_instance.py » ('j') | build/android/pylib/perf/perf_test_instance.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import fnmatch	5 import fnmatch

6 import functools	6 import functools

7 import imp	7 import imp

8 import logging	8 import logging

9 import signal	9 import signal

10 import thread	10 import thread

(...skipping 182 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
193 return test	193 return test

194	194

195 def _GetTests(self):	195 def _GetTests(self):

196 raise NotImplementedError	196 raise NotImplementedError

197	197

198 def _RunTest(self, device, test):	198 def _RunTest(self, device, test):

199 raise NotImplementedError	199 raise NotImplementedError

200	200

201 def _ShouldShard(self):	201 def _ShouldShard(self):

202 raise NotImplementedError	202 raise NotImplementedError

	203

	204 class NoTestsError(Exception):
	jbudorick 2016/06/28 10:27:33 If we're raising this when we have no perf tests, If we're raising this when we have no perf tests, we should probably also raise it when we have no gtests or instrumentation tests. rnephew (Reviews Here) 2016/06/29 22:27:19 Would you like that in this CL, or in a CL after t Show quoted text On 2016/06/28 10:27:33, jbudorick (EMEA til June 30) wrote: > If we're raising this when we have no perf tests, we should probably also raise > it when we have no gtests or instrumentation tests. Would you like that in this CL, or in a CL after this lands? jbudorick 2016/07/01 14:20:09 hm, probably a separate CL after this lands. Show quoted text On 2016/06/29 22:27:19, rnephew (Reviews Here) wrote: > On 2016/06/28 10:27:33, jbudorick (EMEA til June 30) wrote: > > If we're raising this when we have no perf tests, we should probably also > raise > > it when we have no gtests or instrumentation tests. > > Would you like that in this CL, or in a CL after this lands? hm, probably a separate CL after this lands.
	205 """Error for when no tests are found."""

OLD	NEW