build/android/pylib/base/test_instance_factory.py - Issue 2012323002: [Android] Implement perf tests to platform mode.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/pylib/base/test_instance_factory.py

Issue 2012323002: [Android] Implement perf tests to platform mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add retry logic and some clean up Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from pylib.gtest import gtest_test_instance	5 from pylib.gtest import gtest_test_instance

6 from pylib.instrumentation import instrumentation_test_instance	6 from pylib.instrumentation import instrumentation_test_instance

	7 from pylib.perf import perf_test_instance

7 from pylib.uirobot import uirobot_test_instance	8 from pylib.uirobot import uirobot_test_instance

8 from pylib.utils import isolator	9 from pylib.utils import isolator

9	10

10	11

11 def CreateTestInstance(args, error_func):	12 def CreateTestInstance(args, error_func):

12	13

13 if args.command == 'gtest':	14 if args.command == 'gtest':

14 return gtest_test_instance.GtestTestInstance(	15 return gtest_test_instance.GtestTestInstance(

15 args, isolator.Isolator(), error_func)	16 args, isolator.Isolator(), error_func)

16 elif args.command == 'instrumentation':	17 elif args.command == 'instrumentation':

17 return instrumentation_test_instance.InstrumentationTestInstance(	18 return instrumentation_test_instance.InstrumentationTestInstance(

18 args, isolator.Isolator(), error_func)	19 args, isolator.Isolator(), error_func)

19 elif args.command == 'uirobot':	20 elif args.command == 'uirobot':

20 return uirobot_test_instance.UirobotTestInstance(args, error_func)	21 return uirobot_test_instance.UirobotTestInstance(args, error_func)

	22 elif args.command == 'perf':
	mikecase (-- gone --) 2016/06/01 17:40:27 suuuuuuuper nit: alphabetize maybe suuuuuuuper nit: alphabetize maybe jbudorick 2016/06/01 17:44:11 nit: alphabetize nit: alphabetize rnephew (Reviews Here) 2016/06/01 20:32:04 Done. Show quoted text On 2016/06/01 17:40:27, mikecase wrote: > suuuuuuuper nit: alphabetize maybe Done.
	23 return perf_test_instance.PerfTestInstance(args, error_func)

21	24

22 error_func('Unable to create %s test instance.' % args.command)	25 error_func('Unable to create %s test instance.' % args.command)

OLD	NEW

« no previous file with comments | « no previous file | build/android/pylib/base/test_run_factory.py » ('j') | build/android/pylib/base/test_run_factory.py » ('J')