Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2012313002: Use a larger font in the extension badge when possible. (Closed)

Created:
4 years, 6 months ago by Evan Stade
Modified:
4 years, 6 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a larger font in the extension badge when possible. BUG=613576 Committed: https://crrev.com/8ad66522f53d6d74da96d2c31f5af7c72bfb3673 Cr-Commit-Position: refs/heads/master@{#396347}

Patch Set 1 #

Total comments: 2

Patch Set 2 : failed attempt at optimization #

Patch Set 3 : revert failure #

Patch Set 4 : fix failure to revert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M chrome/browser/ui/extensions/icon_with_badge_image_source.cc View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Evan Stade
seems to have a minor effet on my local system, especially at dsf=2 (pictured here) ...
4 years, 6 months ago (2016-05-26 19:42:01 UTC) #2
Devlin
lgtm. I'm a little worried this won't be sufficient (if there was another character there, ...
4 years, 6 months ago (2016-05-26 20:50:26 UTC) #3
Evan Stade
On 2016/05/26 20:50:26, Devlin wrote: > lgtm. I'm a little worried this won't be sufficient ...
4 years, 6 months ago (2016-05-26 21:49:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012313002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012313002/60001
4 years, 6 months ago (2016-05-26 21:51:22 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-05-27 01:41:11 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 01:42:28 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8ad66522f53d6d74da96d2c31f5af7c72bfb3673
Cr-Commit-Position: refs/heads/master@{#396347}

Powered by Google App Engine
This is Rietveld 408576698