Use a larger font in the extension badge when possible.

Use a larger font in the extension badge when possible.

BUG=613576
Committed: https://crrev.com/8ad66522f53d6d74da96d2c31f5af7c72bfb3673
Cr-Commit-Position: refs/heads/master@{#396347}

[Evan Stade, 2016-05-26 19:42:01]

estade@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[Evan Stade, 2016-05-26 19:42:01]

seems to have a minor effet on my local system, especially at dsf=2 (pictured
here)

https://screenshot.googleplex.com/dV3HNuKJCAZ.png

[Devlin, 2016-05-26 20:50:26]

lgtm.  I'm a little worried this won't be sufficient (if there was another
character there, it seems like the effect would be nonexistent), but it's a
start.

https://codereview.chromium.org/2012313002/diff/1/chrome/browser/ui/extension...
File chrome/browser/ui/extensions/icon_with_badge_image_source.cc (right):

https://codereview.chromium.org/2012313002/diff/1/chrome/browser/ui/extension...
chrome/browser/ui/extensions/icon_with_badge_image_source.cc:188: int w, h;
nit: I think style requires these to be initialized (and on separate lines).

[Evan Stade, 2016-05-26 21:49:38]

On 2016/05/26 20:50:26, Devlin wrote:
> lgtm.  I'm a little worried this won't be sufficient (if there was another
> character there, it seems like the effect would be nonexistent), but it's a
> start.

you mean if there were a much taller character there? Presumably that would be a
good thing unless you're proposing increasing the height of the badge. I think
the badge is still the same size as before, the only difference is that we moved
to a dynamic font size calculation to handle i18n and system fonts better
(hardcoding might mean some text could overflow vertically).

I'm slightly worried about the performance cost of all these text renders and
size calculations but it doesn't seem trivial to fix this as
IconWithBadgeImageSource is constantly getting created from scratch.

https://codereview.chromium.org/2012313002/diff/1/chrome/browser/ui/extension...
File chrome/browser/ui/extensions/icon_with_badge_image_source.cc (right):

https://codereview.chromium.org/2012313002/diff/1/chrome/browser/ui/extension...
chrome/browser/ui/extensions/icon_with_badge_image_source.cc:188: int w, h;
On 2016/05/26 20:50:25, Devlin wrote:
> nit: I think style requires these to be initialized (and on separate lines).

Done.

[Evan Stade, 2016-05-26 21:49:42]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-05-26 21:49:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2012313002/#ps40001
(title: "revert failure")

[Evan Stade, 2016-05-26 21:49:53]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2016-05-26 21:50:39]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-05-26 21:50:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2012313002/#ps60001
(title: "fix failure to revert")

[commit-bot: I haz the power, 2016-05-26 21:51:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2012313002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2012313002/60001

[commit-bot: I haz the power, 2016-05-27 01:41:11]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-27 01:42:26]

Description was changed from

==========
Use a larger font in the extension badge when possible.

BUG=613576
==========

to

==========
Use a larger font in the extension badge when possible.

BUG=613576

Committed: https://crrev.com/8ad66522f53d6d74da96d2c31f5af7c72bfb3673
Cr-Commit-Position: refs/heads/master@{#396347}
==========

[commit-bot: I haz the power, 2016-05-27 01:42:28]

Patchset 4 (id:??) landed as
https://crrev.com/8ad66522f53d6d74da96d2c31f5af7c72bfb3673
Cr-Commit-Position: refs/heads/master@{#396347}