Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2012303002: [Merge to 2743] Revert "[Reland 2] Pepper takes ownership of a mailbox before passing it to the tex… (Closed)

Created:
4 years, 6 months ago by erikchen
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Merge to 2743] Revert "[Reland 2] Pepper takes ownership of a mailbox before passing it to the texture layer." The CL has at least one bug, so reverting it from 2743 is the safest course of action. BUG=611016 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=ccameron@chromium.org, bbudge@chromium.org, sky@chromium.org, tsepez@chromium.org, piman@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/294d74675a0d09e7a59e221f96fed28ba259499b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -539 lines) Patch
M cc/layers/texture_layer.h View 1 chunk +6 lines, -0 lines 0 comments Download
M cc/layers/texture_layer.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M cc/layers/texture_layer_unittest.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M components/mus/gles2/command_buffer_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/mus/gles2/command_buffer_impl.cc View 1 chunk +1 line, -6 lines 0 comments Download
M components/mus/public/interfaces/command_buffer.mojom View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.h View 4 chunks +3 lines, -51 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 4 chunks +16 lines, -95 lines 0 comments Download
M content/renderer/pepper/ppb_graphics_3d_impl.h View 4 chunks +7 lines, -14 lines 0 comments Download
M content/renderer/pepper/ppb_graphics_3d_impl.cc View 6 chunks +10 lines, -39 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 2 chunks +1 line, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 6 chunks +3 lines, -123 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_mock.h View 1 chunk +1 line, -4 lines 0 comments Download
M gpu/command_buffer/tests/gl_texture_mailbox_unittest.cc View 6 chunks +24 lines, -114 lines 0 comments Download
M gpu/ipc/client/command_buffer_proxy_impl.h View 1 chunk +1 line, -4 lines 0 comments Download
M gpu/ipc/client/command_buffer_proxy_impl.cc View 1 chunk +4 lines, -14 lines 0 comments Download
M gpu/ipc/common/gpu_messages.h View 2 chunks +2 lines, -14 lines 0 comments Download
M gpu/ipc/service/gpu_channel.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M gpu/ipc/service/gpu_command_buffer_stub.h View 2 chunks +1 line, -3 lines 0 comments Download
M gpu/ipc/service/gpu_command_buffer_stub.cc View 4 chunks +6 lines, -19 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.cc View 4 chunks +0 lines, -17 lines 0 comments Download
M ppapi/thunk/ppb_graphics_3d_api.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (4 generated)
erikchen
4 years, 6 months ago (2016-05-26 19:34:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
294d74675a0d09e7a59e221f96fed28ba259499b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698