Source/core/html/HTMLSelectElement.cpp - Issue 20123003: [oilpan] The Node hierarchy should have correct accept method chains

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLSelectElement.cpp

Issue 20123003: [oilpan] The Node hierarchy should have correct accept method chains (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLSelectElement.cpp

diff --git a/Source/core/html/HTMLSelectElement.cpp b/Source/core/html/HTMLSelectElement.cpp

index 0681e0b7bf55a242ac454dd27aa2fa1f968ca9a4..0b829c5135ffd40f0600dea564ce6d4d84c9c4d3 100644

--- a/Source/core/html/HTMLSelectElement.cpp

+++ b/Source/core/html/HTMLSelectElement.cpp

@@ -468,7 +468,7 @@ void HTMLSelectElement::setLength(unsigned newLen, ExceptionCode& ec)

Vector<RefPtr<Element> > itemsToRemove;

size_t optionIndex = 0;

for (size_t i = 0; i < items.size(); ++i) {

- NoHandleScope scope;

+ HandleScope scope;

Element* item = items[i];

if (item->hasLocalName(optionTag) && optionIndex++ >= newLen) {

ASSERT(item->parentNode());

« no previous file with comments | « Source/core/html/HTMLSelectElement.h ('k') | Source/core/html/HTMLSourceElement.h » ('j') | no next file with comments »