Source/core/html/HTMLScriptElement.cpp - Issue 20123003: [oilpan] The Node hierarchy should have correct accept method chains

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLScriptElement.cpp

Issue 20123003: [oilpan] The Node hierarchy should have correct accept method chains (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLScriptElement.cpp

diff --git a/Source/core/html/HTMLScriptElement.cpp b/Source/core/html/HTMLScriptElement.cpp

index 40f85e5a2d17770de63b65b5bcd615f8b28a50c8..c1d951c997ad28d4c1bc68a619b11a3c025eb526 100644

--- a/Source/core/html/HTMLScriptElement.cpp

+++ b/Source/core/html/HTMLScriptElement.cpp

@@ -176,6 +176,9 @@ PassRefPtr<Element> HTMLScriptElement::cloneElementWithoutAttributesAndChildren(

return adoptRef(new HTMLScriptElement(tagQName(), document(), false, alreadyStarted()));

}

+// FIXME(oilpan): There is multiple inheritance going on here. This is a ScriptElement as

Mads Ager (chromium) 2013/07/25 13:35:12 Yup, thanks for adding the comment here. :)

+// well as an HTMLElement. The ScriptElement has a Element member that we should deal with

+// as well. We need to treat ScriptElement in the same way that we did for TreeScope.

void HTMLScriptElement::acceptHeapVisitor(Visitor* visitor) const

{

HTMLElement::acceptHeapVisitor(visitor);

« Source/core/html/HTMLMeterElement.cpp ('K') | « Source/core/html/HTMLProgressElement.cpp ('k') | Source/core/html/HTMLSelectElement.h » ('j') | Source/core/html/HTMLSelectElement.h » ('J')