Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2012283003: Update API: MojoReduceRights() -> MojoReplaceHandleWithReducedRights(). (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Update API: MojoReduceRights() -> MojoReplaceHandleWithReducedRights(). Just update mojo/public/c/system/handle.h; no implementation yet. R=jamesr@chromium.org BUG=fixes #783 Committed: https://chromium.googlesource.com/external/mojo/+/910c5448926fa16d8a0a25eaa92253cb3b505a0c

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M mojo/public/c/system/handle.h View 2 chunks +19 lines, -10 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 7 months ago (2016-05-26 19:36:27 UTC) #1
jamesr
lgtm https://codereview.chromium.org/2012283003/diff/1/mojo/public/c/system/handle.h File mojo/public/c/system/handle.h (right): https://codereview.chromium.org/2012283003/diff/1/mojo/public/c/system/handle.h#newcode139 mojo/public/c/system/handle.h:139: // data pipes) on |handle| will be aborted. ...
4 years, 7 months ago (2016-05-26 19:51:39 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-26 20:09:35 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
910c5448926fa16d8a0a25eaa92253cb3b505a0c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698