Issue 2012233003: fix poi test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2012233003: fix poi test (Closed)

Created:
4 years, 7 months ago by Harry Terkelsen

Modified:
4 years, 7 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

fix poi test Fixes #26538 Committed: https://github.com/dart-lang/sdk/commit/9850a83bdbef89ead8b53b16c1f75fb79afeb618

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	site/try/poi/poi.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Harry Terkelsen

Committed patchset #1 (id:1) manually as 9850a83bdbef89ead8b53b16c1f75fb79afeb618 (presubmit successful).

4 years, 7 months ago (2016-05-26 18:01:17 UTC) #4

Siggi Cherem (dart-lang)

4 years, 7 months ago (2016-05-26 19:19:56 UTC) #5

Message was sent while issue was closed.

lgtm

It might not matter because this is only used for testing the incremental
compile now, but I'll chat with you offline to see if we need to actually store
the compiler in the subclass instead.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages