Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 2012203002: Rename OwnPtr::clear() to reset(). (Closed)

Created:
4 years, 7 months ago by Yuta Kitamura
Modified:
4 years, 6 months ago
Reviewers:
*haraken, *tzik
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, blink-reviews-bindings_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename OwnPtr::clear() to reset(). The function is renamed to prepare for OwnPtr-to-std::unique_ptr migration. BUG=611661 Committed: https://crrev.com/6845561457d7391db78d2a025de9aa02bb5f7f33 Cr-Commit-Position: refs/heads/master@{#396418}

Patch Set 1 #

Patch Set 2 : Rebase for landing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/OwnPtr.h View 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012203002/1
4 years, 7 months ago (2016-05-26 06:03:14 UTC) #2
Yuta Kitamura
NOTE: I will plan to send a PSA on this, and will wait for a ...
4 years, 7 months ago (2016-05-26 06:09:08 UTC) #5
tzik
lgtm
4 years, 7 months ago (2016-05-26 07:17:34 UTC) #6
haraken
LGTM
4 years, 7 months ago (2016-05-26 07:38:00 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-26 10:02:55 UTC) #9
commit-bot: I haz the power
Dry run: None
4 years, 7 months ago (2016-05-26 10:03:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012203002/20001
4 years, 6 months ago (2016-05-27 05:25:10 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-27 07:32:05 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 07:33:14 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6845561457d7391db78d2a025de9aa02bb5f7f33
Cr-Commit-Position: refs/heads/master@{#396418}

Powered by Google App Engine
This is Rietveld 408576698