Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2012193002: Use image instead of CSS in layout test network-memory-cached-resource.html (Closed)

Created:
4 years, 7 months ago by hiroshige
Modified:
4 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use image instead of CSS in layout test network-memory-cached-resource.html If we make references from MemoryCache to Resource weak, stylesheet Resource might be destructed because LinkStyle doesn't keep a strong reference to Resource after loading is done. This CL makes network-memory-cached-resource.html to use an image instead of CSS to make the cached resource alive during the test. BUG=603462 Committed: https://crrev.com/41f261a0bc951dbd256f6d33ac739c9bcad07b13 Cr-Commit-Position: refs/heads/master@{#402130}

Patch Set 1 #

Messages

Total messages: 23 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012193002/1
4 years, 7 months ago (2016-05-26 05:56:01 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-26 07:00:24 UTC) #4
commit-bot: I haz the power
Dry run: None
4 years, 7 months ago (2016-05-26 07:00:35 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012193002/1
4 years, 6 months ago (2016-06-14 12:20:24 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-14 15:07:47 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2012193002/1
4 years, 5 months ago (2016-06-26 10:51:55 UTC) #12
hiroshige
PTAL.
4 years, 5 months ago (2016-06-26 10:52:50 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-26 12:03:35 UTC) #16
dgozman
lgtm
4 years, 5 months ago (2016-06-26 14:50:58 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2012193002/1
4 years, 5 months ago (2016-06-27 07:18:16 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 07:22:27 UTC) #21
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 07:25:04 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41f261a0bc951dbd256f6d33ac739c9bcad07b13
Cr-Commit-Position: refs/heads/master@{#402130}

Powered by Google App Engine
This is Rietveld 408576698