Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Issue 2012183003: VM: Field::IsConsistentWith should check unboxing state of the field. (Closed)

Created:
4 years, 7 months ago by Vyacheslav Egorov (Google)
Modified:
4 years, 7 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Field::IsConsistentWith should check unboxing state of the field. R=fschneider@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/bfa8a7a2a3156e5857f882b7cfeb3de98fc98b9b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M runtime/vm/object.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Vyacheslav Egorov (Google)
4 years, 7 months ago (2016-05-26 13:08:59 UTC) #1
Florian Schneider
LGTM
4 years, 7 months ago (2016-05-26 13:13:59 UTC) #2
Vyacheslav Egorov (Google)
4 years, 7 months ago (2016-05-26 13:14:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bfa8a7a2a3156e5857f882b7cfeb3de98fc98b9b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698