Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2012163003: Fix several element properties in serialization. (Closed)

Created:
4 years, 7 months ago by Johnni Winther
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : dartfmt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -32 lines) Patch
M pkg/compiler/lib/src/elements/common.dart View 1 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 2 chunks +3 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 1 1 chunk +9 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/member_impl.dart View 2 chunks +7 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/serialization/element_serialization.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 12 chunks +84 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/serialization/equivalence_test.dart View 6 chunks +46 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_helper.dart View 7 chunks +46 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 7 months ago (2016-05-26 10:44:23 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 7 months ago (2016-05-26 22:43:01 UTC) #3
Johnni Winther
4 years, 7 months ago (2016-05-27 08:37:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
dd4368e21751e6fb6842ecbfc217a0fd6ea902ee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698