Remove one (of several) usages of SetPrivateData from IFWL_Widget

Remove one (of several) usages of SetPrivateData from IFWL_Widget

Allow an upper layer to store an "event key" directly in the
widget.  Also fix some dubious logic in key allocation.

Committed: https://pdfium.googlesource.com/pdfium/+/d2b93dfa15dbb7fd42b7cf05fc248d7f5c87f1ef

[Tom Sepez, 2016-05-26 00:40:10]

https://codereview.chromium.org/2012143003/diff/1/xfa/fwl/core/fwl_noteimp.cpp
File xfa/fwl/core/fwl_noteimp.cpp (left):

https://codereview.chromium.org/2012143003/diff/1/xfa/fwl/core/fwl_noteimp.cp...
xfa/fwl/core/fwl_noteimp.cpp:111: void* random = FX_Random_MT_Start(0);
Note: FX's random number generator will give the same sequence from the same
seed, I think, so after seeding it, use the C RTL one to get better values,
completely ignoring the FX one.  And these will never collide, right?  What are
the odds ... (hint: good somewhere).

[Tom Sepez, 2016-05-26 00:40:21]

Description was changed from

==========
Remove one (of several) usages of SetPrivateData from IFWL_Widget

Allow an upper layer to store an "event key" directly in the
widget.  Also fix some dubious logic in key allocation.
==========

to

==========
Remove one (of several) usages of SetPrivateData from IFWL_Widget

Allow an upper layer to store an "event key" directly in the
widget.  Also fix some dubious logic in key allocation.
==========

[Tom Sepez, 2016-05-26 00:40:21]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-05-26 00:40:37]

Lei, for review.  Kinda scary.

[Tom Sepez, 2016-05-26 00:42:20]

https://codereview.chromium.org/2012143003/diff/1/xfa/fwl/core/fwl_noteimp.cpp
File xfa/fwl/core/fwl_noteimp.cpp (left):

https://codereview.chromium.org/2012143003/diff/1/xfa/fwl/core/fwl_noteimp.cp...
xfa/fwl/core/fwl_noteimp.cpp:111: void* random = FX_Random_MT_Start(0);
On 2016/05/26 00:40:10, Tom Sepez wrote:
> Note: FX's random number generator will give the same sequence from the same
> seed, I think, so after seeding it, use the C RTL one to get better values,
> completely ignoring the FX one.  And these will never collide, right?  What
are
> the odds ... (hint: good somewhere).
And it never returns 0, right?

[Lei Zhang, 2016-05-26 01:32:20]

lgtm

https://codereview.chromium.org/2012143003/diff/1/xfa/fwl/core/fwl_widgetimp.cpp
File xfa/fwl/core/fwl_widgetimp.cpp (right):

https://codereview.chromium.org/2012143003/diff/1/xfa/fwl/core/fwl_widgetimp....
xfa/fwl/core/fwl_widgetimp.cpp:102: return
static_cast<CFWL_WidgetImp*>(GetImpl())->GetEventKey();
GetImpl() and many other calls to it in this file all don't need the static
cast.

[Tom Sepez, 2016-05-26 16:15:55]

https://codereview.chromium.org/2012143003/diff/1/xfa/fwl/core/fwl_widgetimp.cpp
File xfa/fwl/core/fwl_widgetimp.cpp (right):

https://codereview.chromium.org/2012143003/diff/1/xfa/fwl/core/fwl_widgetimp....
xfa/fwl/core/fwl_widgetimp.cpp:102: return
static_cast<CFWL_WidgetImp*>(GetImpl())->GetEventKey();
On 2016/05/26 01:32:20, Lei Zhang wrote:
> GetImpl() and many other calls to it in this file all don't need the static
> cast.

Done.

[Tom Sepez, 2016-05-26 16:15:59]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-05-26 16:16:00]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2012143003/#ps20001
(title: "Remove casts")

[commit-bot: I haz the power, 2016-05-26 16:16:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2012143003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2012143003/20001

[commit-bot: I haz the power, 2016-05-26 16:40:34]

Description was changed from

==========
Remove one (of several) usages of SetPrivateData from IFWL_Widget

Allow an upper layer to store an "event key" directly in the
widget.  Also fix some dubious logic in key allocation.
==========

to

==========
Remove one (of several) usages of SetPrivateData from IFWL_Widget

Allow an upper layer to store an "event key" directly in the
widget.  Also fix some dubious logic in key allocation.

Committed:
https://pdfium.googlesource.com/pdfium/+/d2b93dfa15dbb7fd42b7cf05fc248d7f5c87...
==========

[commit-bot: I haz the power, 2016-05-26 16:40:35]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/d2b93dfa15dbb7fd42b7cf05fc248d7f5c87...