Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2012133003: SkPDF/SkColorSpace: use writeToICC (Closed)

Created:
4 years, 7 months ago by hal.canary
Modified:
4 years, 7 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : 2016-05-26 (Thursday) 11:17:15 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -111 lines) Patch
M src/pdf/SkPDFDocument.cpp View 1 2 chunks +3 lines, -111 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
hal.canary
PTAL. Is there a way to avoid the cast? Is the data valid?
4 years, 7 months ago (2016-05-26 15:03:54 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012133003/1
4 years, 7 months ago (2016-05-26 15:07:08 UTC) #5
msarett
You can use as_CSB() instead of the cast. lgtm https://codereview.chromium.org/2012133003/diff/1/src/pdf/SkPDFDocument.cpp File src/pdf/SkPDFDocument.cpp (right): https://codereview.chromium.org/2012133003/diff/1/src/pdf/SkPDFDocument.cpp#newcode322 src/pdf/SkPDFDocument.cpp:322: ...
4 years, 7 months ago (2016-05-26 15:11:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012133003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012133003/20001
4 years, 7 months ago (2016-05-26 15:17:27 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 15:31:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/99e22fbe569ef3525d4de07eceaca2200a3d6e50

Powered by Google App Engine
This is Rietveld 408576698