Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: runtime/vm/service.cc

Issue 201213004: Use VM tag in profile and add stack trace trie (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/profiler.cc ('k') | runtime/vm/service_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index 8907dc3dc1ac98af485de9c28d17df01d0974f03..35178e3007804bff98da41b2dd03cb6f1f71fb42 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -1374,7 +1374,16 @@ static bool HandleProfile(Isolate* isolate, JSONStream* js) {
// A full profile includes disassembly of all Dart code objects.
// TODO(johnmccutchan): Add sub command to trigger full code dump.
bool full_profile = false;
- Profiler::PrintToJSONStream(isolate, js, full_profile);
+ const char* tags_option = js->LookupOption("tags");
+ bool use_tags = true;
+ if (tags_option != NULL) {
+ if (strcmp("hide", tags_option) != 0) {
+ PrintError(js, "Invalid tags option value: %s\n", tags_option);
+ return true;
+ }
+ use_tags = false;
+ }
+ Profiler::PrintToJSONStream(isolate, js, full_profile, use_tags);
return true;
}
« no previous file with comments | « runtime/vm/profiler.cc ('k') | runtime/vm/service_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698