Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Unified Diff: runtime/bin/vmservice/client/lib/src/app/view_model.dart

Issue 201213004: Use VM tag in profile and add stack trace trie (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/app/view_model.dart
diff --git a/runtime/bin/vmservice/client/lib/src/app/view_model.dart b/runtime/bin/vmservice/client/lib/src/app/view_model.dart
index e832dcacf52a49fa5ca3fc9324aebef540b38858..dda6c81ab8dc743269607d1fd861e3d40d6e691b 100644
--- a/runtime/bin/vmservice/client/lib/src/app/view_model.dart
+++ b/runtime/bin/vmservice/client/lib/src/app/view_model.dart
@@ -42,18 +42,16 @@ abstract class TableTreeRow extends Observable {
}
class TableTree extends Observable {
- final List<String> columnHeaders = [];
@observable final List<TableTreeRow> rows = toObservable([]);
/// Create a table tree with column [headers].
- TableTree(List<String> headers) {
- columnHeaders.addAll(headers);
- }
+ TableTree();
/// Initialize the table tree with the list of root children.
- void initialize(List<TableTreeRow> children) {
+ void initialize(TableTreeRow root) {
rows.clear();
- rows.addAll(children);
+ root.onShow();
+ rows.addAll(root.children);
}
/// Toggle expansion of row at [rowIndex].
@@ -70,20 +68,10 @@ class TableTree extends Observable {
int _index(TableTreeRow row) => rows.indexOf(row);
- void _insertRow(int index, TableTreeRow row) {
- if (index == -1) {
- rows.add(row);
- } else {
- rows.insert(index, row);
- }
- }
-
void _expand(TableTreeRow row) {
int index = _index(row);
assert(index != -1);
- for (var i = 0; i < row.children.length; i++) {
- _insertRow(index + i + 1, row.children[i]);
- }
+ rows.insertAll(index + 1, row.children);
}
void _collapse(TableTreeRow row) {
@@ -101,8 +89,6 @@ class TableTree extends Observable {
row.expanded = false;
// Remove all children.
int index = _index(row);
- for (var i = 0; i < childCount; i++) {
- rows.removeAt(index + 1);
- }
+ rows.removeRange(index + 1, index + 1 + childCount);
}
}
« no previous file with comments | « runtime/bin/vmservice/client/lib/elements.html ('k') | runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698