Use VM tag in profile and add stack trace trie

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/cpu.h"
@@ skipping 22 matching lines @@
 #include "vm/intrinsifier.h"
 #include "vm/longjump.h"
 #include "vm/object_id_ring.h"
 #include "vm/object_store.h"
 #include "vm/parser.h"
 #include "vm/reusable_handles.h"
 #include "vm/runtime_entry.h"
 #include "vm/scopes.h"
 #include "vm/stack_frame.h"
 #include "vm/symbols.h"
+#include "vm/tags.h"
 #include "vm/timer.h"
 #include "vm/unicode.h"
 
 namespace dart {
 
 DEFINE_FLAG(int, huge_method_cutoff_in_code_size, 200000,
     "Huge method cutoff in unoptimized code size (in bytes).");
 DEFINE_FLAG(int, huge_method_cutoff_in_tokens, 20000,
     "Huge method cutoff in tokens: Disables optimizations for huge methods.");
 DEFINE_FLAG(bool, overlap_type_arguments, true,
@@ skipping 7309 matching lines @@
   StorePointer(&raw_ptr()->tokens_, value.raw());
 }
 
 
 void Script::Tokenize(const String& private_key) const {
   const TokenStream& tkns = TokenStream::Handle(tokens());
   if (!tkns.IsNull()) {
     // Already tokenized.
     return;
   }
-
+  Isolate* isolate = Isolate::Current();

[siva, 2014/03/18 00:05:20]

Please hoist this up as the first line and use
tkns = TokenStream::Handle(isolate, tokens());

[Cutch, 2014/03/18 14:39:19]

Done.

   // Get the source, scan and allocate the token stream.
+  VMTagScope tagScope(isolate, VMTag::kCompileTagId);
   TimerScope timer(FLAG_compiler_stats, &CompilerStats::scanner_timer);
   const String& src = String::Handle(Source());

[siva, 2014/03/18 00:05:20]

Now that we have grabbed the isolate:
src = String::Handle(isolate, Source());

[Cutch, 2014/03/18 14:39:19]

Done.

   Scanner scanner(src, private_key);
   set_tokens(TokenStream::Handle(TokenStream::New(scanner.GetStream(),
                                                   private_key)));

[siva, 2014/03/18 00:05:20]

Ditto.

[Cutch, 2014/03/18 14:39:19]

Done.

   if (FLAG_compiler_stats) {
     CompilerStats::src_length += src.Length();
   }
 }
 
 
 void Script::SetLocationOffset(intptr_t line_offset,
                                intptr_t col_offset) const {
   ASSERT(line_offset >= 0);
   ASSERT(col_offset >= 0);
@@ skipping 10308 matching lines @@
   return "_MirrorReference";
 }
 
 
 void MirrorReference::PrintToJSONStream(JSONStream* stream, bool ref) const {
   Instance::PrintToJSONStream(stream, ref);
 }
 
 
 }  // namespace dart