Remove uses of SkBitmap::Config (deprecated) from core/ and platform/.

Source/platform/graphics/GraphicsContext.cpp

Index: Source/platform/graphics/GraphicsContext.cpp
diff --git a/Source/platform/graphics/GraphicsContext.cpp b/Source/platform/graphics/GraphicsContext.cpp
index 3e9d6602fab72d5a902791d958f0e90c48af665b..bae0eef0c1d881408d328b430629671e9042b196 100644
--- a/Source/platform/graphics/GraphicsContext.cpp
+++ b/Source/platform/graphics/GraphicsContext.cpp
@@ -780,9 +780,7 @@ void GraphicsContext::drawLineForDocumentMarker(const FloatPoint& pt, float widt
         const int rowPixels = 4 * deviceScaleFactor;
         const int colPixels = 3 * deviceScaleFactor;
         misspellBitmap[index] = new SkBitmap;
-        misspellBitmap[index]->setConfig(SkBitmap::kARGB_8888_Config,
-                                         rowPixels, colPixels);
-        misspellBitmap[index]->allocPixels();
+        misspellBitmap[index]->allocN32Pixels(rowPixels, colPixels);

[jbroman, 2014/03/17 16:46:38]

This does not handle the case where the allocation fails (and false is
returned), but neither did it before.

The core seems to be assuming that this cannot happen, since draw[12]xMarker
will call getAddr32 on the result regardless, which triggers an SkASSERT and
then (if asserts aren't enabled returns and uses an address near 0x0).

I'd appreciate schenney's opinion on whether, or how, we should handle this
case. One option might be to free the SkBitmap and early-return.

 
         misspellBitmap[index]->eraseARGB(0, 0, 0, 0);
         const uint32_t transparentColor = 0x00000000;
@@ -837,8 +835,7 @@ void GraphicsContext::drawLineForDocumentMarker(const FloatPoint& pt, float widt
         const int rowPixels = 32 * deviceScaleFactor; // Must be multiple of 4 for pattern below.
         const int colPixels = 2 * deviceScaleFactor;
         misspellBitmap[index] = new SkBitmap;
-        misspellBitmap[index]->setConfig(SkBitmap::kARGB_8888_Config, rowPixels, colPixels);
-        misspellBitmap[index]->allocPixels();
+        misspellBitmap[index]->allocN32Pixels(rowPixels, colPixels);

[jbroman, 2014/03/17 16:46:38]

And here as well.

 
         misspellBitmap[index]->eraseARGB(0, 0, 0, 0);
         if (deviceScaleFactor == 1)