Remove uses of SkBitmap::Config (deprecated) from core/ and platform/.

Source/platform/graphics/GraphicsContext.cpp

 /*
  * Copyright (C) 2003, 2004, 2005, 2006, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 762 matching lines @@
     int index = style == DocumentMarkerGrammarLineStyle ? 1 : 0;
     static SkBitmap* misspellBitmap1x[2] = { 0, 0 };
     static SkBitmap* misspellBitmap2x[2] = { 0, 0 };
     SkBitmap** misspellBitmap = deviceScaleFactor == 2 ? misspellBitmap2x : misspellBitmap1x;
     if (!misspellBitmap[index]) {
 #if OS(MACOSX)
         // Match the artwork used by the Mac.
         const int rowPixels = 4 * deviceScaleFactor;
         const int colPixels = 3 * deviceScaleFactor;
         misspellBitmap[index] = new SkBitmap;
-        misspellBitmap[index]->setConfig(SkBitmap::kARGB_8888_Config,
-                                         rowPixels, colPixels);
-        misspellBitmap[index]->allocPixels();
+        misspellBitmap[index]->allocN32Pixels(rowPixels, colPixels);

[Stephen Chennney, 2014/03/18 12:47:57]

On failure, release and return without drawing, please. We've seen bugs with
this kind of thing before.

[jbroman, 2014/03/18 13:44:52]

Done. Rather than try to use "delete" here (which is prone to being missed if
other returns appear), I've opted to use an SkBitmap on the stack to do the
drawing (which is properly freed if we cannot allocate pixels), and then move it
into misspellBitmap after it succeeds.

 
         misspellBitmap[index]->eraseARGB(0, 0, 0, 0);
         const uint32_t transparentColor = 0x00000000;
 
         if (deviceScaleFactor == 1) {
             const uint32_t colors[2][6] = {
                 { 0x2a2a0600, 0x57571000,  0xa8a81b00, 0xbfbf1f00,  0x70701200, 0xe0e02400 },
                 { 0x2a0f0f0f, 0x571e1e1e,  0xa83d3d3d, 0xbf454545,  0x70282828, 0xe0515151 }
             };
 
@@ skipping 34 matching lines @@
             }
         } else
             ASSERT_NOT_REACHED();
 #else
         // We use a 2-pixel-high misspelling indicator because that seems to be
         // what WebKit is designed for, and how much room there is in a typical
         // page for it.
         const int rowPixels = 32 * deviceScaleFactor; // Must be multiple of 4 for pattern below.
         const int colPixels = 2 * deviceScaleFactor;
         misspellBitmap[index] = new SkBitmap;
-        misspellBitmap[index]->setConfig(SkBitmap::kARGB_8888_Config, rowPixels, colPixels);
-        misspellBitmap[index]->allocPixels();
+        misspellBitmap[index]->allocN32Pixels(rowPixels, colPixels);

[Stephen Chennney, 2014/03/18 12:47:57]

Ditto.

 
         misspellBitmap[index]->eraseARGB(0, 0, 0, 0);
         if (deviceScaleFactor == 1)
             draw1xMarker(misspellBitmap[index], index);
         else if (deviceScaleFactor == 2)
             draw2xMarker(misspellBitmap[index], index);
         else
             ASSERT_NOT_REACHED();
 #endif
     }
@@ skipping 1063 matching lines @@
 
 void GraphicsContext::didDrawTextInRect(const SkRect& textRect)
 {
     if (m_trackTextRegion) {
         TRACE_EVENT0("skia", "PlatformContextSkia::trackTextRegion");
         m_textRegion.join(textRect);
     }
 }
 
 }