Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2012063002: Only SchedulePaint on ShelfWidget if background changes. (Closed)

Created:
4 years, 7 months ago by jbauman
Modified:
4 years, 6 months ago
Reviewers:
oshima, varkha, reveman
CC:
chromium-reviews, kalyank, sadrul, reveman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only SchedulePaint on ShelfWidget if background changes. This is called whenever a toplevel window is moved, and was always doing a SchedulePaint even if no property changed. The BackgroundAnimator will do an UpdateBackground if the alpha changes, so the higher-level SchedulePaint is redundant. BUG=614193 Committed: https://crrev.com/9a944f96a6dbb2d6b702b2b24329e0bf2e149705 Cr-Commit-Position: refs/heads/master@{#397645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M ash/shelf/shelf_widget.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
jbauman
4 years, 7 months ago (2016-05-25 22:51:22 UTC) #2
oshima
Is this urgent? If not, I'd like varkha@, who added this, to look at this ...
4 years, 6 months ago (2016-05-26 19:45:24 UTC) #4
jbauman
On 2016/05/26 19:45:24, oshima wrote: > Is this urgent? If not, I'd like varkha@, who ...
4 years, 6 months ago (2016-05-26 22:46:35 UTC) #5
varkha
This lgtm. I have tried it with various shelf animations and they seem to be ...
4 years, 6 months ago (2016-06-02 20:36:53 UTC) #6
oshima
lgtm
4 years, 6 months ago (2016-06-02 21:26:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012063002/1
4 years, 6 months ago (2016-06-02 21:27:22 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/240452)
4 years, 6 months ago (2016-06-03 00:42:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012063002/1
4 years, 6 months ago (2016-06-03 05:00:46 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 05:57:47 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 05:58:57 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a944f96a6dbb2d6b702b2b24329e0bf2e149705
Cr-Commit-Position: refs/heads/master@{#397645}

Powered by Google App Engine
This is Rietveld 408576698