Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2012043002: Remove base dependency from webapk/libs/client (Closed)

Created:
4 years, 7 months ago by pkotwicz
Modified:
4 years, 7 months ago
Reviewers:
Xi Han, Yaron
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, Xi Han
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove base dependency from webapk/libs/client BUG=611421 Committed: https://crrev.com/2f51b95ab526d0bac7b08ed525ec51e27850c119 Cr-Commit-Position: refs/heads/master@{#396117}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Messages

Total messages: 17 (8 generated)
pkotwicz
Xi can you please take a look?
4 years, 7 months ago (2016-05-25 20:29:01 UTC) #2
Xi Han
lgtm
4 years, 7 months ago (2016-05-25 21:08:25 UTC) #3
pkotwicz
Yaron, can you please take a look at the changes in chrome/android/java ?
4 years, 7 months ago (2016-05-25 21:23:51 UTC) #5
Yaron
nice - lgtm
4 years, 7 months ago (2016-05-25 21:33:07 UTC) #6
Yaron
https://codereview.chromium.org/2012043002/diff/1/chrome/android/webapk/libs/client/DEPS File chrome/android/webapk/libs/client/DEPS (left): https://codereview.chromium.org/2012043002/diff/1/chrome/android/webapk/libs/client/DEPS#oldcode2 chrome/android/webapk/libs/client/DEPS:2: "+base", err, you should probably also remove this from: ...
4 years, 7 months ago (2016-05-25 21:34:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012043002/20001
4 years, 7 months ago (2016-05-25 22:19:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012043002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012043002/40001
4 years, 7 months ago (2016-05-26 01:38:36 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-26 04:12:56 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 04:14:48 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2f51b95ab526d0bac7b08ed525ec51e27850c119
Cr-Commit-Position: refs/heads/master@{#396117}

Powered by Google App Engine
This is Rietveld 408576698