Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

Issue 2012033002: DevTools: more previews when formatting logged arrays/objects (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code cleanup Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 503 matching lines...) Expand 10 before | Expand all | Expand 10 after
514 { 514 {
515 return this._preview; 515 return this._preview;
516 }, 516 },
517 517
518 /** 518 /**
519 * @override 519 * @override
520 * @param {function(?Array.<!WebInspector.RemoteObjectProperty>, ?Array.<!We bInspector.RemoteObjectProperty>)} callback 520 * @param {function(?Array.<!WebInspector.RemoteObjectProperty>, ?Array.<!We bInspector.RemoteObjectProperty>)} callback
521 */ 521 */
522 getOwnProperties: function(callback) 522 getOwnProperties: function(callback)
523 { 523 {
524 this.doGetProperties(true, false, false, callback); 524 this.doGetProperties(true, false, true, callback);
525 }, 525 },
526 526
527 /** 527 /**
528 * @override 528 * @override
529 * @param {boolean} accessorPropertiesOnly 529 * @param {boolean} accessorPropertiesOnly
530 * @param {function(?Array.<!WebInspector.RemoteObjectProperty>, ?Array.<!We bInspector.RemoteObjectProperty>)} callback 530 * @param {function(?Array.<!WebInspector.RemoteObjectProperty>, ?Array.<!We bInspector.RemoteObjectProperty>)} callback
531 */ 531 */
532 getAllProperties: function(accessorPropertiesOnly, callback) 532 getAllProperties: function(accessorPropertiesOnly, callback)
533 { 533 {
534 this.doGetProperties(false, accessorPropertiesOnly, false, callback); 534 this.doGetProperties(false, accessorPropertiesOnly, false, callback);
(...skipping 681 matching lines...) Expand 10 before | Expand all | Expand 10 after
1216 */ 1216 */
1217 _concatenate: function(prefix, suffix, formatProperty) 1217 _concatenate: function(prefix, suffix, formatProperty)
1218 { 1218 {
1219 var previewChars = 100; 1219 var previewChars = 100;
1220 1220
1221 var buffer = prefix; 1221 var buffer = prefix;
1222 var children = this._children(); 1222 var children = this._children();
1223 for (var i = 0; i < children.length; ++i) { 1223 for (var i = 0; i < children.length; ++i) {
1224 var itemDescription = formatProperty(children[i]); 1224 var itemDescription = formatProperty(children[i]);
1225 if (buffer.length + itemDescription.length > previewChars) { 1225 if (buffer.length + itemDescription.length > previewChars) {
1226 buffer += ",\u2026"; 1226 buffer += ", \u2026";
1227 break; 1227 break;
1228 } 1228 }
1229 if (i) 1229 if (i)
1230 buffer += ", "; 1230 buffer += ", ";
1231 buffer += itemDescription; 1231 buffer += itemDescription;
1232 } 1232 }
1233 buffer += suffix; 1233 buffer += suffix;
1234 return buffer; 1234 return buffer;
1235 }, 1235 },
1236 1236
(...skipping 371 matching lines...) Expand 10 before | Expand all | Expand 10 after
1608 { 1608 {
1609 if (!this._cachedDescription) { 1609 if (!this._cachedDescription) {
1610 var children = this._children(); 1610 var children = this._children();
1611 this._cachedDescription = "{" + this._formatValue(children[0].value) + " => " + this._formatValue(children[1].value) + "}"; 1611 this._cachedDescription = "{" + this._formatValue(children[0].value) + " => " + this._formatValue(children[1].value) + "}";
1612 } 1612 }
1613 return this._cachedDescription; 1613 return this._cachedDescription;
1614 }, 1614 },
1615 1615
1616 __proto__: WebInspector.LocalJSONObject.prototype 1616 __proto__: WebInspector.LocalJSONObject.prototype
1617 } 1617 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698