DevTools: more previews when formatting logged arrays/objects

third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

 /*
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 334 matching lines @@
         if (this._message.type === WebInspector.ConsoleMessage.MessageType.Table) {
             formattedResult.appendChild(this._formatParameterAsTable(parameters));
             return formattedResult;
         }
 
         // Single parameter, or unused substitutions from above.
         for (var i = 0; i < parameters.length; ++i) {
             // Inline strings when formatting.
             if (shouldFormatMessage && parameters[i].type === "string")
                 formattedResult.appendChild(WebInspector.linkifyStringAsFragment(parameters[i].description));
+            else if (parameters[i].type === "function")
+                formattedResult.appendChild(this._formatParameter(parameters[i], true, true));
             else
                 formattedResult.appendChild(this._formatParameter(parameters[i], false, true));
             if (i < parameters.length - 1)
                 formattedResult.createTextChild(" ");
         }
         return formattedResult;
     },
 
     /**
      * @param {!WebInspector.RemoteObject} output
@@ skipping 48 matching lines @@
             titleElement.classList.add("console-object-preview");
             this._previewFormatter.appendObjectPreview(titleElement, obj.preview);
         } else {
             if (obj.type === "function") {
                 WebInspector.ObjectPropertiesSection.formatObjectAsFunction(obj, titleElement, false);
                 titleElement.classList.add("object-value-function");
             } else {
                 titleElement.createTextChild(obj.description || "");
             }
         }
+        var expandedTitleElement = createElement("span");
+        expandedTitleElement.createTextChild(obj.description || "");
         var note = titleElement.createChild("span", "object-state-note");
         note.classList.add("info-note");
         note.title = WebInspector.UIString("Object value at left was snapshotted when logged, value below was evaluated just now.");
-        var section = new WebInspector.ObjectPropertiesSection(obj, titleElement);
+        var section = new WebInspector.ObjectPropertiesSection(obj, titleElement, expandedTitleElement);
         section.enableContextMenu();
         elem.appendChild(section.element);
         section.element.classList.add("console-view-object-properties-section");
     },
 
     /**
      * @param {!WebInspector.RemoteObject} func
      * @param {!Element} element
      * @param {boolean=} includePreview
      */
@@ skipping 67 matching lines @@
             this._formatParameterAsObject(object, elem, false);
         }
     },
 
     _formattedParameterAsNodeForTest: function()
     {
     },
 
     /**
      * @param {!WebInspector.RemoteObject} array
-     * @return {boolean}
-     */
-    useArrayPreviewInFormatter: function(array)
-    {
-        return this._message.type !== WebInspector.ConsoleMessage.MessageType.DirXML;
-    },
-
-    /**
-     * @param {!WebInspector.RemoteObject} array
      * @param {!Element} elem
      */
     _formatParameterAsArray: function(array, elem)
     {
-        var maxFlatArrayLength = 100;
-        if (this.useArrayPreviewInFormatter(array) || array.arrayLength() > maxFlatArrayLength)
-            this._formatParameterAsArrayOrObject(array, elem, this.useArrayPreviewInFormatter(array) || array.arrayLength() <= maxFlatArrayLength);
-        else
-            array.getAllProperties(false, this._printArray.bind(this, array, elem));
+        this._formatParameterAsArrayOrObject(array, elem, true);
     },
 
     /**
      * @param {!Array.<!WebInspector.RemoteObject>} parameters
      * @return {!Element}
      */
     _formatParameterAsTable: function(parameters)
     {
         var element = createElementWithClass("div", "console-message-formatted-table");
         var table = parameters[0];
@@ skipping 790 matching lines @@
     {
         if (!this._wrapperElement) {
             WebInspector.ConsoleViewMessage.prototype.toMessageElement.call(this);
             this._wrapperElement.classList.toggle("collapsed", this._collapsed);
         }
         return this._wrapperElement;
     },
 
     __proto__: WebInspector.ConsoleViewMessage.prototype
 }