Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 201203006: Move basic API permissions code out of //chrome (Closed)

Created:
6 years, 9 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 9 months ago
Reviewers:
James Cook
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Move basic API permissions code out of //chrome This stuff can live in //extensions, and moving it there allows us to kill a few more //chrome entries from extensions deps. Also //chrome/common/extensions/api/messaging/message.h moves to //extensions/common/api/messaging/message.h because it's cheap and easy. BUG=354602 TBR=kalman@chromium.org TBR=bryueng@chromium.org for device/usb dep Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258534

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1

Patch Set 3 : move moar things #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -2088 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/hid/hid_api.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_api.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/message_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api_helpers.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/usb/usb_api.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_extension_web_contents_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/media_galleries_dialog_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/media_galleries_dialog_controller_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/media_galleries_preferences.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/media_galleries_preferences_unittest.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/media_scan_manager_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 2 2 chunks +0 lines, -20 lines 0 comments Download
D chrome/common/extensions/api/messaging/message.h View 1 chunk +0 lines, -22 lines 0 comments Download
M chrome/common/extensions/api/sockets/sockets_manifest_permission.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_permission_message_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/permissions/media_galleries_permission.h View 1 2 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/common/extensions/permissions/media_galleries_permission.cc View 1 2 1 chunk +0 lines, -157 lines 0 comments Download
D chrome/common/extensions/permissions/media_galleries_permission_data.h View 1 2 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/common/extensions/permissions/media_galleries_permission_data.cc View 1 2 1 chunk +0 lines, -62 lines 0 comments Download
M chrome/common/extensions/permissions/media_galleries_permission_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/common/extensions/permissions/permission_message_util.h View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/common/extensions/permissions/permission_message_util.cc View 1 chunk +0 lines, -150 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/common/extensions/permissions/set_disjunction_permission.h View 1 chunk +0 lines, -170 lines 0 comments Download
D chrome/common/extensions/permissions/settings_override_permission.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/common/extensions/permissions/settings_override_permission.cc View 1 chunk +0 lines, -111 lines 0 comments Download
M chrome/common/extensions/permissions/settings_override_permission_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/permissions/socket_permission.h View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/common/extensions/permissions/socket_permission.cc View 1 chunk +0 lines, -110 lines 0 comments Download
D chrome/common/extensions/permissions/socket_permission_data.h View 1 chunk +0 lines, -87 lines 0 comments Download
D chrome/common/extensions/permissions/socket_permission_data.cc View 1 chunk +0 lines, -159 lines 0 comments Download
D chrome/common/extensions/permissions/socket_permission_entry.h View 1 chunk +0 lines, -86 lines 0 comments Download
D chrome/common/extensions/permissions/socket_permission_entry.cc View 1 chunk +0 lines, -227 lines 0 comments Download
M chrome/common/extensions/permissions/socket_permission_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/permissions/usb_device_permission.h View 1 2 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/common/extensions/permissions/usb_device_permission.cc View 1 2 1 chunk +0 lines, -74 lines 0 comments Download
D chrome/common/extensions/permissions/usb_device_permission_data.h View 1 2 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/common/extensions/permissions/usb_device_permission_data.cc View 1 2 1 chunk +0 lines, -109 lines 0 comments Download
M chrome/common/extensions/permissions/usb_device_permission_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/dispatcher.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/extension_helper.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/messaging_bindings.cc View 2 chunks +1 line, -1 line 0 comments Download
M extensions/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/socket/socket_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/DEPS View 1 2 2 chunks +1 line, -2 lines 0 comments Download
A + extensions/common/api/messaging/message.h View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/common/extension_messages.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
A + extensions/common/permissions/media_galleries_permission.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
A + extensions/common/permissions/media_galleries_permission.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/permissions/media_galleries_permission_data.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/permissions/media_galleries_permission_data.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + extensions/common/permissions/permission_message_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/permissions/permission_message_util.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M extensions/common/permissions/permissions_data_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
A + extensions/common/permissions/set_disjunction_permission.h View 7 chunks +31 lines, -29 lines 0 comments Download
A + extensions/common/permissions/settings_override_permission.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + extensions/common/permissions/settings_override_permission.cc View 4 chunks +13 lines, -17 lines 0 comments Download
A + extensions/common/permissions/socket_permission.h View 2 chunks +10 lines, -10 lines 0 comments Download
A + extensions/common/permissions/socket_permission.cc View 5 chunks +22 lines, -24 lines 0 comments Download
A + extensions/common/permissions/socket_permission_data.h View 2 chunks +8 lines, -6 lines 0 comments Download
A + extensions/common/permissions/socket_permission_data.cc View 5 chunks +8 lines, -9 lines 0 comments Download
A + extensions/common/permissions/socket_permission_entry.h View 4 chunks +8 lines, -10 lines 0 comments Download
A + extensions/common/permissions/socket_permission_entry.cc View 8 chunks +19 lines, -20 lines 0 comments Download
A + extensions/common/permissions/usb_device_permission.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
A + extensions/common/permissions/usb_device_permission.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/permissions/usb_device_permission_data.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/permissions/usb_device_permission_data.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/extensions.gyp View 1 2 3 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Ken Rockot(use gerrit already)
Purely a mechanical move + clang_format change.
6 years, 9 months ago (2014-03-20 20:40:49 UTC) #1
James Cook
LGTM https://codereview.chromium.org/201203006/diff/20001/extensions/browser/DEPS File extensions/browser/DEPS (left): https://codereview.chromium.org/201203006/diff/20001/extensions/browser/DEPS#oldcode24 extensions/browser/DEPS:24: "+chrome/common/extensions/permissions", w00t
6 years, 9 months ago (2014-03-20 20:57:01 UTC) #2
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 9 months ago (2014-03-20 20:57:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/201203006/20001
6 years, 9 months ago (2014-03-20 21:00:59 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 22:34:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 9 months ago (2014-03-20 22:34:09 UTC) #6
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 9 months ago (2014-03-20 23:11:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/201203006/40001
6 years, 9 months ago (2014-03-20 23:12:44 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 02:09:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 9 months ago (2014-03-21 02:09:06 UTC) #10
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 9 months ago (2014-03-21 02:54:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/201203006/40001
6 years, 9 months ago (2014-03-21 02:54:50 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 11:48:35 UTC) #13
Message was sent while issue was closed. 
Change committed as 258534

Powered by Google App Engine
This is Rietveld 408576698