Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Issue 201203002: Revert of Implement ScopedFD in terms of ScopedGeneric. (Closed)

Created:
6 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 9 months ago
Reviewers:
brettw, agl, viettrungluu
CC:
chromium-reviews, nkostylev+watch_chromium.org, gavinp+memory_chromium.org, stevenjb+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, fischman+watch_chromium.org, craigdh+watch_chromium.org, feature-media-reviews_chromium.org, bulach+watch_chromium.org, oshima+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, agl, tfarina, mcasas+watch_chromium.org, robertshield, davemoore+watch_chromium.org, stgao, wjia+watch_chromium.org, jln+watch_chromium.org
Visibility:
Public.

Description

Revert of Implement ScopedFD in terms of ScopedGeneric. (https://codereview.chromium.org/191673003/) Reason for revert: Doesn't correctly link /mnt/data/b/build/slave/Chromium_Linux_Codesearch/build/src/third_party/gold/gold64: warning: hidden symbol 'base::internal::ScopedFDCloseTraits::Free(int)' in obj/base/files/nacl_helper.scoped_file.o is referenced by DSO lib/libipc.so Original issue's description: > Implement ScopedFD in terms of ScopedGeneric. > > Move to a new file base/files/scoped_file.h. I will also add ScopedFILE to here (currently in file_util.h) later. > > I think there is a crash in the old code in content/browser/zygote_host/zygote_host_impl_linux.cc that this patch should fix. The old ScopedFD took the address of something in a vector that is being modified. > > I removed SafeScopedFD from content/common/sandbox_linux/sandbox_linux.cc since base's ScopedFD not CHECKs on close failure (this is a more recent addition). > > BUG= > R=agl@chromium.org, viettrungluu@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257001 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257179 TBR=viettrungluu@chromium.org,agl@chromium.org,brettw@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257323

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+292 lines, -338 lines) Patch
M base/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M base/base.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M base/debug/proc_maps_linux.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M base/file_util.h View 1 chunk +26 lines, -0 lines 0 comments Download
M base/file_util_posix.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M base/file_util_unittest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
D base/files/scoped_file.h View 1 chunk +0 lines, -47 lines 0 comments Download
D base/files/scoped_file.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M base/memory/discardable_memory_allocator_android.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M base/memory/shared_memory.h View 2 chunks +1 line, -2 lines 0 comments Download
M base/memory/shared_memory_posix.cc View 8 chunks +14 lines, -10 lines 0 comments Download
M base/posix/unix_domain_socket_linux_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M base/process/kill_mac.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M base/process/kill_posix.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M base/process/launch_posix.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M base/test/launcher/test_launcher.cc View 3 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/system/automatic_reboot_manager.cc View 3 chunks +11 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc View 3 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/mac/relauncher.cc View 7 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/process_singleton_mac_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/test/automation/proxy_launcher.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/chromedriver/chrome_launcher.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/utility/importer/firefox_importer_unittest_utils_mac.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/child_process_launcher.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M content/browser/zygote_host/zygote_host_impl_linux.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/child/npapi/np_channel_base.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M content/common/sandbox_linux/sandbox_linux.cc View 4 chunks +15 lines, -11 lines 0 comments Download
M content/common/sandbox_mac.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M content/common/sandbox_mac_system_access_unittest.mm View 3 chunks +7 lines, -6 lines 0 comments Download
M ipc/ipc_channel_factory.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ipc/unix_domain_socket_util.cc View 7 chunks +25 lines, -24 lines 0 comments Download
M media/video/capture/linux/video_capture_device_linux.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/video/capture/linux/video_capture_device_linux.cc View 21 chunks +40 lines, -37 lines 0 comments Download
M net/test/spawned_test_server/local_test_server.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/test/spawned_test_server/local_test_server_posix.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M sandbox/linux/services/broker_process_unittest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M sandbox/linux/services/credentials_unittest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M sandbox/linux/services/scoped_process_unittest.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M sandbox/linux/services/yama.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/android/memdump/memdump.cc View 5 chunks +13 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Implement ScopedFD in terms of ScopedGeneric.
6 years, 9 months ago (2014-03-15 13:33:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/201203002/1
6 years, 9 months ago (2014-03-15 13:34:07 UTC) #2
commit-bot: I haz the power
Change committed as 257323
6 years, 9 months ago (2014-03-15 13:35:10 UTC) #3
brettw
Wasn't that a nonfatal warning? It was landed fine most of the day.
6 years, 9 months ago (2014-03-16 02:48:30 UTC) #4
jochen (gone - plz use gerrit)
On 2014/03/16 02:48:30, brettw wrote: > Wasn't that a nonfatal warning? It was landed fine ...
6 years, 9 months ago (2014-03-16 12:26:38 UTC) #5
brettw
I link to the failing bot would have been helpful. I can't reproduce the warning.
6 years, 9 months ago (2014-03-17 16:54:35 UTC) #6
jochen (gone - plz use gerrit)
On 2014/03/17 16:54:35, brettw wrote: > I link to the failing bot would have been ...
6 years, 9 months ago (2014-03-17 16:59:44 UTC) #7
brettw
6 years, 9 months ago (2014-03-17 17:02:43 UTC) #8
Message was sent while issue was closed.
On 2014/03/17 16:59:44, jochen wrote:
> On 2014/03/17 16:54:35, brettw wrote:
> > I link to the failing bot would have been helpful. I can't reproduce the
> > warning.
> 
> I meanwhile ripped out the offending gyp stuff, so we should just revert the
> revert.

Oh, no wonder it's working for me. Thanks.

Powered by Google App Engine
This is Rietveld 408576698