Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2012023002: Fix AST-based type inference via interfaces. (Closed)

Created:
4 years, 7 months ago by Paul Berry
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -21 lines) Patch
M pkg/analyzer/lib/src/summary/link.dart View 7 chunks +30 lines, -21 lines 2 comments Download
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 3 chunks +243 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 7 months ago (2016-05-25 20:17:29 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2012023002/diff/1/pkg/analyzer/lib/src/summary/link.dart File pkg/analyzer/lib/src/summary/link.dart (right): https://codereview.chromium.org/2012023002/diff/1/pkg/analyzer/lib/src/summary/link.dart#newcode2186 pkg/analyzer/lib/src/summary/link.dart:2186: library: library, thisType: true); "thisType" is already true ...
4 years, 7 months ago (2016-05-25 20:21:21 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as 3d00d5d7d128ba88d3da026d0f3379414b0ed084 (presubmit successful).
4 years, 7 months ago (2016-05-25 20:27:45 UTC) #5
Paul Berry
4 years, 7 months ago (2016-05-25 20:28:12 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2012023002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/link.dart (right):

https://codereview.chromium.org/2012023002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/link.dart:2186: library: library, thisType: true);
On 2016/05/25 20:21:21, scheglov wrote:
> "thisType" is already true by default.

Thanks.  Fixed.

Powered by Google App Engine
This is Rietveld 408576698