Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2011973003: WebRTC: Add trybot for iOS SDK Framework build. (Closed)

Created:
4 years, 7 months ago by kjellander_chromium
Modified:
4 years, 7 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

WebRTC: Add trybot for iOS SDK Framework build. To make it possible to prevent breakages. The trybot doesn't clobber previous build output nor upload any artifacts to Google storage, to save resources and speed up cycle time. Not cleaning is safe as long as -b static_only is not passed to webrtc/build/ios/build_ios_libs.sh. BUG=webrtc:5737 TBR=phoglund@chromium.org Committed: https://chromium.googlesource.com/chromium/tools/build/+/0208b2498569deeeac390b6fd1d97edae7ab98b7

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -31 lines) Patch
M masters/master.tryserver.webrtc/master.cfg View 1 chunk +5 lines, -0 lines 0 comments Download
M masters/master.tryserver.webrtc/slaves.cfg View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/ios_api_framework.py View 3 chunks +23 lines, -14 lines 2 comments Download
A + scripts/slave/recipes/webrtc/ios_api_framework.expected/trybot_biuld.json View 3 chunks +11 lines, -17 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011973003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011973003/1
4 years, 7 months ago (2016-05-25 18:30:02 UTC) #2
kjellander_chromium
4 years, 7 months ago (2016-05-25 18:30:13 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-25 18:36:05 UTC) #6
commit-bot: I haz the power
Dry run: None
4 years, 7 months ago (2016-05-25 18:36:13 UTC) #7
kjellander_chromium
TBRing since now is a good time to restart the tryserver.
4 years, 7 months ago (2016-05-26 04:22:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011973003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011973003/1
4 years, 7 months ago (2016-05-26 04:22:50 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/0208b2498569deeeac390b6fd1d97edae7ab98b7
4 years, 7 months ago (2016-05-26 04:26:47 UTC) #13
phoglund_chromium
lgtm https://codereview.chromium.org/2011973003/diff/1/scripts/slave/recipes/webrtc/ios_api_framework.py File scripts/slave/recipes/webrtc/ios_api_framework.py (right): https://codereview.chromium.org/2011973003/diff/1/scripts/slave/recipes/webrtc/ios_api_framework.py#newcode70 scripts/slave/recipes/webrtc/ios_api_framework.py:70: api.test('trybot_biuld') + biuld? That doesn't look right. I ...
4 years, 7 months ago (2016-05-26 07:30:07 UTC) #14
kjellander_chromium
4 years, 7 months ago (2016-05-26 08:11:59 UTC) #15
Message was sent while issue was closed.
Follow up: https://codereview.chromium.org/2009983003

https://codereview.chromium.org/2011973003/diff/1/scripts/slave/recipes/webrt...
File scripts/slave/recipes/webrtc/ios_api_framework.py (right):

https://codereview.chromium.org/2011973003/diff/1/scripts/slave/recipes/webrt...
scripts/slave/recipes/webrtc/ios_api_framework.py:70: api.test('trybot_biuld') +
On 2016/05/26 07:30:07, phoglund_chrome wrote:
> biuld? That doesn't look right. I guess it's not a big deal since it just
> affects the tests.

Right, it only affects the name of the expectation file. I'm correcting it in
https://codereview.chromium.org/2009983003 though.

Powered by Google App Engine
This is Rietveld 408576698