lib/src/compiler/code_generator.dart - Issue 2011973002: Add generic types to Sort and Comparable. Fix crasher bug in codegen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/compiler/code_generator.dart

Issue 2011973002: Add generic types to Sort and Comparable. Fix crasher bug in codegen. (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/src/compiler/code_generator.dart

diff --git a/lib/src/compiler/code_generator.dart b/lib/src/compiler/code_generator.dart

index ba65adf354cb69cffa88c9b4bcc8fb43bc2759e8..3ea5a2254ef071e5b2ba29821bdd2b99ba14b4ba 100644

--- a/lib/src/compiler/code_generator.dart

+++ b/lib/src/compiler/code_generator.dart

@@ -3111,7 +3111,7 @@ class CodeGenerator extends GeneralizingAstVisitor

var args = _visit(argumentList) as List<JS.Expression>;

return isFactory ? new JS.Call(ctor, args) : new JS.New(ctor, args);

}

- if (_isObjectLiteral(element.enclosingElement)) {

Jacob 2016/05/25 16:38:04 this was crashing on some google3 code.

+ if (element != null && _isObjectLiteral(element.enclosingElement)) {

return _emitObjectLiteral(argumentList);

}

if (isConst) return _emitConst(emitNew);

« no previous file with comments | « lib/runtime/dart_sdk.js ('k') | tool/input_sdk/lib/core/comparable.dart » ('j') | no next file with comments »