chrome/browser/ui/views/website_settings/permissions_bubble_view.cc - Issue 2011963002: PermissionSelectorView: use Combobox on MacViews builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

Issue 2011963002: PermissionSelectorView: use Combobox on MacViews builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Give up on SetPermissionInfo Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/website_settings/permission_selector_view.cc ('k') | chrome/browser/ui/views/website_settings/website_settings_popup_view_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

diff --git a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

index da0b51f2e74bb5ce4ccb4f3f574eb625da928673..066900f7696c87c5e564b12879387c617e661c27 100644

--- a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

+++ b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

@@ -132,6 +132,7 @@ void PermissionCombobox::OnMenuButtonClicked(views::MenuButton* source,

void PermissionCombobox::PermissionChanged(

const WebsiteSettingsUI::PermissionInfo& permission) {

+ LOG(ERROR) << "PermissionChanged!";

SetText(model_->GetLabelAt(model_->GetIndexOfCommandId(permission.setting)));

SizeToPreferredSize();