Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2011943005: MD History/Downloads: Update toolbar and background color (Closed)

Created:
4 years, 7 months ago by tsergeant
Modified:
4 years, 6 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, asanka, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History/Downloads: Update toolbar and background color Updates colors to match latest specs BUG=614590 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/b403f7be0f0fb1cac7d3478b92c8c171060b4785 Cr-Commit-Position: refs/heads/master@{#397007}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update Downloads toolbar buttons #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -151 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 1 2 chunks +106 lines, -115 lines 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.css View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 8 chunks +31 lines, -25 lines 0 comments Download
M chrome/browser/resources/md_history/app.html View 2 chunks +6 lines, -5 lines 0 comments Download
M ui/webui/resources/css/md_colors.css View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Dan Beam
lgtm https://codereview.chromium.org/2011943005/diff/1/ui/webui/resources/css/md_colors.css File ui/webui/resources/css/md_colors.css (right): https://codereview.chromium.org/2011943005/diff/1/ui/webui/resources/css/md_colors.css#newcode11 ui/webui/resources/css/md_colors.css:11: --md-toolbar-color: rgb(51, 103, 214); great minds hack alike
4 years, 6 months ago (2016-05-31 23:10:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011943005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011943005/1
4 years, 6 months ago (2016-05-31 23:19:50 UTC) #5
tsergeant
dbeam: I've updated the Downloads button colors as well
4 years, 6 months ago (2016-05-31 23:48:30 UTC) #7
Dan Beam
lgtm
4 years, 6 months ago (2016-06-01 00:03:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011943005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011943005/20001
4 years, 6 months ago (2016-06-01 00:04:54 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-01 01:00:50 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 01:01:52 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b403f7be0f0fb1cac7d3478b92c8c171060b4785
Cr-Commit-Position: refs/heads/master@{#397007}

Powered by Google App Engine
This is Rietveld 408576698