Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2011893002: [wasm] Added DCHECKs that the input of the Int64Lowering is not null. (Closed)

Created:
4 years, 7 months ago by ahaas
Modified:
4 years, 7 months ago
Reviewers:
titzer, bradnelson
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Added DCHECKs that the input of the Int64Lowering is not null. R=bradnelson@chromium.org, titzer@chromium.org Committed: https://crrev.com/229b66a5176e3d9b5bdf067fa53c6d4f3a00ce12 Cr-Commit-Position: refs/heads/master@{#36516}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/compiler/int64-lowering.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
ahaas
4 years, 7 months ago (2016-05-25 11:39:46 UTC) #1
bradnelson
lgtm
4 years, 7 months ago (2016-05-25 11:41:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011893002/1
4 years, 7 months ago (2016-05-25 12:02:32 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/15977)
4 years, 7 months ago (2016-05-25 12:05:25 UTC) #6
titzer
lgtm
4 years, 7 months ago (2016-05-25 12:51:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011893002/1
4 years, 7 months ago (2016-05-25 13:00:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 13:02:37 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 13:03:36 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/229b66a5176e3d9b5bdf067fa53c6d4f3a00ce12
Cr-Commit-Position: refs/heads/master@{#36516}

Powered by Google App Engine
This is Rietveld 408576698