Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2011883002: Remove unnecessary inclusions of LayoutObject-derived headers in core/frame/ (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 6 months ago
Reviewers:
eae, dcheng
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary inclusions of LayoutObject-derived headers in core/frame/ BUG=614015 TBR=dcheng@chromium.org,eae@chromium.org Committed: https://crrev.com/1781d626ddbf3c9aa2dba3512531110d2cbddfcc Cr-Commit-Position: refs/heads/master@{#395872}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteFrame.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-25 12:23:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011883002/1
4 years, 7 months ago (2016-05-25 12:23:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 12:48:44 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1781d626ddbf3c9aa2dba3512531110d2cbddfcc Cr-Commit-Position: refs/heads/master@{#395872}
4 years, 7 months ago (2016-05-25 12:50:40 UTC) #11
eae
4 years, 6 months ago (2016-05-25 14:55:29 UTC) #12
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698