[wasm] Check that type intersections don't yield empty.

[wasm] Check that type intersections don't yield empty.

Intersection of types is used in several places,
if it yields the empty set, this indicates a type mismatch.
We should emit an error in this case.

Add the RECURSE() macro around IntersectResult to allow errors to propagate immediately.

BUG=614291
R=ahaas@chromium.org
TEST=asm-wasm
LOG=N

Committed: https://crrev.com/cfb4d1e6d7c94b55e518ae8daf28c2a5b1479dfa
Cr-Commit-Position: refs/heads/master@{#36525}

[bradn, 2016-05-25 10:01:25]

Description was changed from

==========
[wasm] Check that type intersections don't yield empty.

Intersection of types is used in several places,
if it yields the empty set, this indicates a type mismatch.
We should emit an error in this case.

BUG=614291
R=ahaas@chromium.org
TEST=asm-wasm
LOG=N
==========

to

==========
[wasm] Check that type intersections don't yield empty.

Intersection of types is used in several places,
if it yields the empty set, this indicates a type mismatch.
We should emit an error in this case.

Add the RECURSE() macro around IntersectResult to allow errors to propagate
immediately.

BUG=614291
R=ahaas@chromium.org
TEST=asm-wasm
LOG=N
==========

[bradn, 2016-05-25 10:01:54]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[ahaas, 2016-05-25 10:09:12]

lgtm

Thanks for making the test.

https://codereview.chromium.org/2011873002/diff/1/src/typing-asm.cc
File src/typing-asm.cc (right):

https://codereview.chromium.org/2011873002/diff/1/src/typing-asm.cc#newcode720
src/typing-asm.cc:720: if (bounds_.get(expr).upper->Is(Type::None())) {
You could just write
DCHECK(bounds_.get(expr).upper->Is(Type::None()));

[bradn, 2016-05-25 16:26:02]

The CQ bit was checked by bradnelson@google.com

[bradn, 2016-05-25 16:26:02]

The patchset sent to the CQ was uploaded after l-g-t-m from ahaas@chromium.org
Link to the patchset: https://codereview.chromium.org/2011873002/#ps60001
(title: "fix")

[commit-bot: I haz the power, 2016-05-25 16:26:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2011873002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2011873002/60001

[bradn, 2016-05-25 16:26:49]

https://codereview.chromium.org/2011873002/diff/1/src/typing-asm.cc
File src/typing-asm.cc (right):

https://codereview.chromium.org/2011873002/diff/1/src/typing-asm.cc#newcode720
src/typing-asm.cc:720: if (bounds_.get(expr).upper->Is(Type::None())) {
On 2016/05/25 10:09:11, ahaas wrote:
> You could just write
> DCHECK(bounds_.get(expr).upper->Is(Type::None()));

Done.

[commit-bot: I haz the power, 2016-05-25 16:33:38]

Description was changed from

==========
[wasm] Check that type intersections don't yield empty.

Intersection of types is used in several places,
if it yields the empty set, this indicates a type mismatch.
We should emit an error in this case.

Add the RECURSE() macro around IntersectResult to allow errors to propagate
immediately.

BUG=614291
R=ahaas@chromium.org
TEST=asm-wasm
LOG=N
==========

to

==========
[wasm] Check that type intersections don't yield empty.

Intersection of types is used in several places,
if it yields the empty set, this indicates a type mismatch.
We should emit an error in this case.

Add the RECURSE() macro around IntersectResult to allow errors to propagate
immediately.

BUG=614291
R=ahaas@chromium.org
TEST=asm-wasm
LOG=N
==========

[commit-bot: I haz the power, 2016-05-25 16:33:40]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-25 16:33:56]

Description was changed from

==========
[wasm] Check that type intersections don't yield empty.

Intersection of types is used in several places,
if it yields the empty set, this indicates a type mismatch.
We should emit an error in this case.

Add the RECURSE() macro around IntersectResult to allow errors to propagate
immediately.

BUG=614291
R=ahaas@chromium.org
TEST=asm-wasm
LOG=N
==========

to

==========
[wasm] Check that type intersections don't yield empty.

Intersection of types is used in several places,
if it yields the empty set, this indicates a type mismatch.
We should emit an error in this case.

Add the RECURSE() macro around IntersectResult to allow errors to propagate
immediately.

BUG=614291
R=ahaas@chromium.org
TEST=asm-wasm
LOG=N

Committed: https://crrev.com/cfb4d1e6d7c94b55e518ae8daf28c2a5b1479dfa
Cr-Commit-Position: refs/heads/master@{#36525}
==========

[commit-bot: I haz the power, 2016-05-25 16:33:57]

Patchset 4 (id:??) landed as
https://crrev.com/cfb4d1e6d7c94b55e518ae8daf28c2a5b1479dfa
Cr-Commit-Position: refs/heads/master@{#36525}