Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2011863002: Revert of "[heap] Fine-grained JSArrayBuffer tracking" (Closed)

Created:
4 years, 7 months ago by Michael Lippautz
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of "[heap] Fine-grained JSArrayBuffer tracking" (patchset #6 id:220001 of https://codereview.chromium.org/2005723005/ ) Reason for revert: Breaking TSAN https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Linux64%20TSAN/builds/9741/steps/Ignition%20-%20turbofan%20%28flakes%29/logs/FixedUint32Array Original issue's description: > Reland of "[heap] Fine-grained JSArrayBuffer tracking" > > Track based on JSArrayBuffer addresses on pages instead of the attached > backing store. > > Details of tracking: > - Scavenge: New space pages are processes in bulk on the main thread > - MC: Unswept pages are processed in bulk in parallel. All other pages > are processed by the sweeper concurrently. > > This reverts commit d2dff0320b75bf6054e46c379b192619d4884caf. > > R=hpayer@chromium.org > BUG=chromium:611688 > LOG=N > CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg,v8_linux64_tsan_rel,v8_mac64_asan_rel > > Committed: https://crrev.com/b5704bc1e6ba74c9ca975f5d58f5b2dc60261457 > Cr-Commit-Position: refs/heads/master@{#36495} TBR=hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:611688 Committed: https://crrev.com/93fe04afa9428f4f68dc5dd302cda83908be84a7 Cr-Commit-Position: refs/heads/master@{#36504}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -598 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/array-buffer-tracker.h View 1 chunk +36 lines, -90 lines 0 comments Download
M src/heap/array-buffer-tracker.cc View 2 chunks +88 lines, -134 lines 0 comments Download
D src/heap/array-buffer-tracker-inl.h View 1 chunk +0 lines, -74 lines 0 comments Download
M src/heap/heap.h View 2 chunks +0 lines, -12 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/mark-compact.cc View 8 chunks +18 lines, -20 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap/scavenger.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/heap/spaces.h View 6 chunks +1 line, -27 lines 0 comments Download
M src/heap/spaces.cc View 3 chunks +1 line, -10 lines 0 comments Download
M src/heap/spaces-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/heap/heap-utils.h View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/heap/heap-utils.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D test/cctest/heap/test-array-buffer-tracker.cc View 1 chunk +0 lines, -206 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Lippautz
Created Revert of "[heap] Fine-grained JSArrayBuffer tracking"
4 years, 7 months ago (2016-05-25 09:37:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011863002/1
4 years, 7 months ago (2016-05-25 09:37:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 09:37:57 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 09:39:07 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93fe04afa9428f4f68dc5dd302cda83908be84a7
Cr-Commit-Position: refs/heads/master@{#36504}

Powered by Google App Engine
This is Rietveld 408576698