Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2011833002: Typed CSSOM: Rename CalcLength and StyleCalcLength to CSSCalcLength (Closed)

Created:
4 years, 7 months ago by rjwright
Modified:
4 years, 6 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Typed CSSOM: Rename CalcLength and StyleCalcLength to CSSCalcLength This CL (along with https://codereview.chromium.org/1997503003/ and https://codereview.chromium.org/2005683002/) replace https://codereview.chromium.org/1949343002/. Changes in line with changes to the spec: https://drafts.css-houdini.org/css-typed-om-1/#lengthvalue-objects Tracking bug: https://bugs.chromium.org/p/chromium/issues/detail?id=610159 BUG=610161 Committed: https://crrev.com/8cfe256fcc559fe384e732b6887855501d5d2081 Cr-Commit-Position: refs/heads/master@{#396407}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -434 lines) Patch
D third_party/WebKit/LayoutTests/typedcssom/calcLength.html View 1 chunk +0 lines, -76 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/cssCalcLength.html View 1 chunk +76 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssLengthValue.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssPositionValue.html View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssSimpleLength.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssTranslation.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/perspectiveTransformComponent.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 4 chunks +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h View 4 chunks +10 lines, -10 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSCalcLength.cpp View 8 chunks +22 lines, -22 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSCalcLength.idl View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSLengthValue.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSSimpleLength.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/CalcLength.idl View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/StyleCalcLength.h View 1 chunk +0 lines, -108 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/StyleCalcLength.cpp View 1 chunk +0 lines, -151 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011833002/1
4 years, 7 months ago (2016-05-25 07:12:12 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-25 09:52:21 UTC) #6
commit-bot: I haz the power
Dry run: None
4 years, 7 months ago (2016-05-25 09:52:29 UTC) #7
rjwright
4 years, 7 months ago (2016-05-26 06:36:34 UTC) #8
Timothy Loh
On 2016/05/26 06:36:34, rjwright wrote: lgtm
4 years, 7 months ago (2016-05-26 07:17:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011833002/1
4 years, 7 months ago (2016-05-26 07:42:49 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/11790) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-26 07:44:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011833002/20001
4 years, 6 months ago (2016-05-27 04:49:30 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-27 06:25:50 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 06:27:00 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8cfe256fcc559fe384e732b6887855501d5d2081
Cr-Commit-Position: refs/heads/master@{#396407}

Powered by Google App Engine
This is Rietveld 408576698