Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2011813002: Rename OwnPtr::clear() to reset() in wtf/. (Closed)

Created:
4 years, 7 months ago by Yuta Kitamura
Modified:
4 years, 7 months ago
Reviewers:
*tzik
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename OwnPtr::clear() to reset() in wtf/. OwnPtr::clear() will soon get renamed to reset() as a part of OwnPtr-to-std::unique_ptr migration. BUG=611661 Committed: https://crrev.com/27d5d23aba040d384b0e9bc524144e59a6cd0403 Cr-Commit-Position: refs/heads/master@{#395842}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/wtf/DequeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/HashMapTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/VectorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Yuta Kitamura
tzik: PTAL?
4 years, 7 months ago (2016-05-25 06:15:44 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011813002/1
4 years, 7 months ago (2016-05-25 06:15:53 UTC) #5
tzik
lgtm
4 years, 7 months ago (2016-05-25 06:20:48 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-25 08:48:21 UTC) #8
commit-bot: I haz the power
Dry run: None
4 years, 7 months ago (2016-05-25 08:48:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011813002/1
4 years, 7 months ago (2016-05-25 09:34:32 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 09:38:38 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 09:42:53 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27d5d23aba040d384b0e9bc524144e59a6cd0403
Cr-Commit-Position: refs/heads/master@{#395842}

Powered by Google App Engine
This is Rietveld 408576698