Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2011783002: Rename OwnPtr::clear() to reset() in platform/. (Closed)

Created:
4 years, 7 months ago by Yuta Kitamura
Modified:
4 years, 7 months ago
Reviewers:
*haraken, *tzik
CC:
chromium-reviews, shans, blink-reviews-platform-graphics_chromium.org, dshwang, rwlbuis, krit, drott+blinkwatch_chromium.org, Justin Novosad, hongchan, Rik, blink-reviews, ajuma+watch_chromium.org, mcasas+watch+mediastream_chromium.org, Eric Willigers, rjwright, jbroman, Raymond Toy, tommyw+watchlist_chromium.org, pdr+graphicswatchlist_chromium.org, darktears, piman+watch_chromium.org, danakj+watch_chromium.org, ajuma+watch-canvas_chromium.org, blink-reviews-animation_chromium.org, blink-layers+watch_chromium.org, f(malita), Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename OwnPtr::clear() to reset() in platform/. OwnPtr::clear() will soon get renamed to reset() as a part of OwnPtr-to-std::unique_ptr migration. BUG=611661 Committed: https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317 Cr-Commit-Position: refs/heads/master@{#395843}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -41 lines) Patch
M third_party/WebKit/Source/platform/WebThreadSupportingGC.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/animation/CompositorFilterKeyframe.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/animation/CompositorTransformKeyframe.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioChannel.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/HRTFDatabaseLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/ReverbConvolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/geometry/TransformState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamComponent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/weborigin/KURL.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011783002/1
4 years, 7 months ago (2016-05-25 06:05:08 UTC) #2
Yuta Kitamura
tzik: PTAL? +haraken for platform/ approval
4 years, 7 months ago (2016-05-25 06:05:28 UTC) #5
tzik
lgtm
4 years, 7 months ago (2016-05-25 06:07:57 UTC) #6
haraken
LGTM
4 years, 7 months ago (2016-05-25 06:58:48 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-25 08:35:32 UTC) #9
commit-bot: I haz the power
Dry run: None
4 years, 7 months ago (2016-05-25 08:35:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011783002/1
4 years, 7 months ago (2016-05-25 09:34:55 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 09:40:05 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 09:42:56 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317
Cr-Commit-Position: refs/heads/master@{#395843}

Powered by Google App Engine
This is Rietveld 408576698