Add an iframe permissions= attribute for implementing permission delegation

third_party/WebKit/Source/core/html/HTMLIFrameElement.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Simon Hausmann <hausmann@kde.org>
  * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  *
  */
 
 #ifndef HTMLIFrameElement_h
 #define HTMLIFrameElement_h
 
+#include "core/CoreExport.h"
 #include "core/html/HTMLFrameElementBase.h"
+#include "core/html/HTMLIFrameElementPermissions.h"
 #include "core/html/HTMLIFrameElementSandbox.h"
+#include "public/platform/WebVector.h"
+#include "public/platform/modules/permissions/WebPermissionType.h"
 
 namespace blink {
 
-class HTMLIFrameElement final : public HTMLFrameElementBase, public DOMTokenListObserver {
+class CORE_EXPORT HTMLIFrameElement final : public HTMLFrameElementBase {
     DEFINE_WRAPPERTYPEINFO();
-    USING_GARBAGE_COLLECTED_MIXIN(HTMLIFrameElement);
 public:
     DECLARE_NODE_FACTORY(HTMLIFrameElement);
     DECLARE_VIRTUAL_TRACE();
     ~HTMLIFrameElement() override;
     DOMTokenList* sandbox() const;
+    DOMTokenList* permissions() const;
+
+    void sandboxValueWasSet();
+    void permissionsValueWasSet();
 
 private:
     explicit HTMLIFrameElement(Document&);
 
     void parseAttribute(const QualifiedName&, const AtomicString&, const AtomicString&) override;
     bool isPresentationAttribute(const QualifiedName&) const override;
     void collectStyleForPresentationAttribute(const QualifiedName&, const AtomicString&, MutableStylePropertySet*) override;
 
     InsertionNotificationRequest insertedInto(ContainerNode*) override;
     void removedFrom(ContainerNode*) override;
 
     bool layoutObjectIsNeeded(const ComputedStyle&) override;
     LayoutObject* createLayoutObject(const ComputedStyle&) override;
 
     bool loadedNonEmptyDocument() const override { return m_didLoadNonEmptyDocument; }
     void didLoadNonEmptyDocument() override { m_didLoadNonEmptyDocument = true; }
     bool isInteractiveContent() const override;
 
-    void valueWasSet() override;
-
     ReferrerPolicy referrerPolicyAttribute() override;
 
     bool allowFullscreen() const override { return m_allowFullscreen; }
 
+    const WebVector<WebPermissionType>* delegatedPermissions() const override { return &m_delegatedPermissions; }

[sof, 2016/06/28 05:29:00]

What is the assumed lifetime of this value? i.e., you're returning a
non-traceable pointer into a Blink heap-allocated object (which might be garbage
collected.)

[raymes, 2016/06/28 06:49:46]

The pointer is just used to reduce copied but the value is used synchronously
and will get copied into the frame owner properties struct.

[sof, 2016/06/28 06:57:48]

ok, it seems unnecessary to resort to returning a pointer here if the call site
substitutes |nullptr| with an empty WebVector.

[raymes, 2016/06/29 05:54:47]

I was trying to reduce copies :) I've returned a const reference instead, which
requires using a static local in the places where null is currently returned.
Otherwise I can return by copy if you feel strongly.

[sof, 2016/06/29 06:10:28]

When & where to optimize is a perennial question, but I think this is fine.

+
+    bool initializePermissionsAttribute();
+
     AtomicString m_name;
     bool m_didLoadNonEmptyDocument;
     bool m_allowFullscreen;
     Member<HTMLIFrameElementSandbox> m_sandbox;
+    Member<HTMLIFrameElementPermissions> m_permissions;
+
+    WebVector<WebPermissionType> m_delegatedPermissions;
 
     ReferrerPolicy m_referrerPolicy;
 };
 
 } // namespace blink
 
 #endif // HTMLIFrameElement_h