Add an iframe permissions= attribute for implementing permission delegation

third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Simon Hausmann (hausmann@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Ericsson AB. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 21 matching lines @@
 #include "core/layout/LayoutIFrame.h"
 
 namespace blink {
 
 using namespace HTMLNames;
 
 inline HTMLIFrameElement::HTMLIFrameElement(Document& document)
     : HTMLFrameElementBase(iframeTag, document)
     , m_didLoadNonEmptyDocument(false)
     , m_sandbox(HTMLIFrameElementSandbox::create(this))
+    , m_permissions(HTMLIFrameElementPermissions::create(this))

[sof, 2016/06/27 08:38:52]

As this isn't commonly accessed (or enabled by default), could we lazily create
|m_permissions| ?

[raymes, 2016/06/28 01:19:03]

Done.

     , m_referrerPolicy(ReferrerPolicyDefault)
 {
 }
 
 DEFINE_NODE_FACTORY(HTMLIFrameElement)
 
 DEFINE_TRACE(HTMLIFrameElement)
 {
     visitor->trace(m_sandbox);
+    visitor->trace(m_permissions);
     HTMLFrameElementBase::trace(visitor);
-    DOMTokenListObserver::trace(visitor);
 }
 
 HTMLIFrameElement::~HTMLIFrameElement()
 {
 }
 
 DOMTokenList* HTMLIFrameElement::sandbox() const
 {
     return m_sandbox.get();
 }
 
+DOMTokenList* HTMLIFrameElement::permissions() const
+{
+    return m_permissions.get();
+}
+
 bool HTMLIFrameElement::isPresentationAttribute(const QualifiedName& name) const
 {
     if (name == widthAttr || name == heightAttr || name == alignAttr || name == frameborderAttr)
         return true;
     return HTMLFrameElementBase::isPresentationAttribute(name);
 }
 
 void HTMLIFrameElement::collectStyleForPresentationAttribute(const QualifiedName& name, const AtomicString& value, MutableStylePropertySet* style)
 {
     if (name == widthAttr) {
@@ skipping 28 matching lines @@
         UseCounter::count(document(), UseCounter::SandboxViaIFrame);
     } else if (name == referrerpolicyAttr) {
         m_referrerPolicy = ReferrerPolicyDefault;
         if (!value.isNull())
             SecurityPolicy::referrerPolicyFromString(value, &m_referrerPolicy);
     } else if (name == allowfullscreenAttr) {
         bool oldAllowFullscreen = m_allowFullscreen;
         m_allowFullscreen = !value.isNull();
         if (m_allowFullscreen != oldAllowFullscreen)
             frameOwnerPropertiesChanged();
+    } else if (name == permissionsAttr) {
+        m_permissions->setValue(value);
     } else {
         if (name == srcAttr)
             logUpdateAttributeIfIsolatedWorldAndInDocument("iframe", srcAttr, oldValue, value);
         HTMLFrameElementBase::parseAttribute(name, oldValue, value);
     }
 }
 
 bool HTMLIFrameElement::layoutObjectIsNeeded(const ComputedStyle& style)
 {
     return isURLAllowed() && HTMLElement::layoutObjectIsNeeded(style);
@@ skipping 18 matching lines @@
     HTMLFrameElementBase::removedFrom(insertionPoint);
     if (insertionPoint->inShadowIncludingDocument() && document().isHTMLDocument() && !insertionPoint->isInShadowTree())
         toHTMLDocument(document()).removeExtraNamedItem(m_name);
 }
 
 bool HTMLIFrameElement::isInteractiveContent() const
 {
     return true;
 }
 
-void HTMLIFrameElement::valueWasSet()
+void HTMLIFrameElement::permissionsValueWasSet()
+{
+    if (!RuntimeEnabledFeatures::permissionDelegationEnabled())
+        return;
+
+    String invalidTokens;
+    m_delegatedPermissions = m_permissions->parseDelegatedPermissions(invalidTokens);
+    if (!invalidTokens.isNull())
+        document().addConsoleMessage(ConsoleMessage::create(OtherMessageSource, ErrorMessageLevel, "Error while parsing the 'permissions' attribute: " + invalidTokens));
+    setSynchronizedLazyAttribute(permissionsAttr, m_permissions->value());
+    frameOwnerPropertiesChanged();
+}
+
+void HTMLIFrameElement::sandboxValueWasSet()
 {
     String invalidTokens;
     setSandboxFlags(m_sandbox->value().isNull() ? SandboxNone : parseSandboxPolicy(m_sandbox->tokens(), invalidTokens));
     if (!invalidTokens.isNull())
         document().addConsoleMessage(ConsoleMessage::create(OtherMessageSource, ErrorMessageLevel, "Error while parsing the 'sandbox' attribute: " + invalidTokens));
     setSynchronizedLazyAttribute(sandboxAttr, m_sandbox->value());
 }
 
 ReferrerPolicy HTMLIFrameElement::referrerPolicyAttribute()
 {
     return m_referrerPolicy;
 }
 } // namespace blink