Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 2011723002: Floor rather than round the top border thickness. (Closed)

Created:
4 years, 7 months ago by Bret
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Floor rather than round the top border thickness to keep it in line with hittests, which are floored. Also use forced scale factor to calculate this value, so maximized windows behave better in that mode. BUG=598469 Committed: https://crrev.com/9e91a05128c2cfea44dac34dee003f7919bf74d3 Cr-Commit-Position: refs/heads/master@{#395955}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 1 chunk +11 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Bret
Follow-up to https://codereview.chromium.org/1978033002
4 years, 7 months ago (2016-05-25 00:37:53 UTC) #3
sky
LGTM
4 years, 7 months ago (2016-05-25 03:27:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011723002/1
4 years, 6 months ago (2016-05-25 17:37:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-25 19:14:22 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-25 19:16:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e91a05128c2cfea44dac34dee003f7919bf74d3
Cr-Commit-Position: refs/heads/master@{#395955}

Powered by Google App Engine
This is Rietveld 408576698