MD Settings: About page, hooking up channel switcher dialog.

chrome/browser/resources/settings/about_page/about_page.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'settings-about-page' contains version and OS related
  * information.
  */
 Polymer({
   is: 'settings-about-page',
@@ skipping 36 matching lines @@
    * is fixed.
    */
   sectionSelector: 'settings-section',
 
   /** @override */
   ready: function() {
     this.browserProxy_ = settings.AboutPageBrowserProxyImpl.getInstance();
     this.browserProxy_.pageReady();
 
 <if expr="chromeos">
+    this.addEventListener('target-channel-changed', function(e) {
+      this.targetChannel_ = e.detail;
+    }.bind(this));

[dschuyler, 2016/05/27 22:16:21]

Just a suggestion: I've sometimes had trouble
with a listener added before attached().
If a change to this value is fine prior to
being attached, then this is fine in ready().
If you're not sure or find a problem, 
this may be better to have in attached().

[dpapad, 2016/05/27 23:32:17]

Moved it to attached.

+
     Promise.all([
       this.browserProxy_.getCurrentChannel(),
       this.browserProxy_.getTargetChannel(),
     ]).then(function(channels) {
       this.currentChannel_ = channels[0];
       this.targetChannel_ = channels[1];
 
       this.startListening_();
     }.bind(this));
 
@@ skipping 49 matching lines @@
     return this.currentUpdateStatusEvent_.status != UpdateStatus.DISABLED;
   },
 
   /**
    * @return {boolean}
    * @private
    */
   shouldShowRelaunch_: function() {
     var shouldShow = false;
 <if expr="not chromeos">
-    shouldShow =
-        this.currentUpdateStatusEvent_.status == UpdateStatus.NEARLY_UPDATED;
+    shouldShow = this.checkStatus_(UpdateStatus.NEARLY_UPDATED);
 </if>
 <if expr="chromeos">
-    shouldShow = !this.isTargetChannelMoreStable_() &&
-        this.currentUpdateStatusEvent_.status == UpdateStatus.NEARLY_UPDATED;
+    shouldShow = this.checkStatus_(UpdateStatus.NEARLY_UPDATED) &&
+        !this.isTargetChannelMoreStable_();
 </if>
     return shouldShow;
   },
 
   /**
    * @return {string}
    * @private
    */
   getUpdateStatusMessage_: function() {
     switch (this.currentUpdateStatusEvent_.status) {
@@ skipping 45 matching lines @@
   getIconSrc_: function() {
     switch (this.currentUpdateStatusEvent_.status) {
       case UpdateStatus.CHECKING:
       case UpdateStatus.UPDATING:
         return 'chrome://resources/images/throbber_small.svg';
       default:
         return null;
     }
   },
 
+  /**
+   * @param {!UpdateStatus} status
+   * @return {boolean}
+   * @private
+   */
+  checkStatus_: function(status) {
+    return this.currentUpdateStatusEvent_.status == status;
+  },
+
 <if expr="chromeos">
   /**
    * @return {boolean}
    * @private
    */
   isTargetChannelMoreStable_: function() {
     assert(this.currentChannel_.length > 0);
     assert(this.targetChannel_.length > 0);
     return settings.isTargetChannelMoreStable(
         this.currentChannel_, this.targetChannel_);
   },
 
   /** @private */
   onDetailedBuildInfoTap_: function() {
     var animatedPages = /** @type {!SettingsAnimatedPagesElement} */ (
         this.$.pages);
     animatedPages.setSubpageChain(['detailed-build-info']);
   },
 
   /** @private */
   onRelaunchAndPowerwashTap_: function() {
     // TODO(dpapad): Implement this.
   },
 
   /**
    * @return {boolean}
    * @private
    */
   shouldShowRelaunchAndPowerwash_: function() {
-    return this.isTargetChannelMoreStable_() &&
-        this.currentUpdateStatusEvent_.status == UpdateStatus.NEARLY_UPDATED;
+    return this.checkStatus_(UpdateStatus.NEARLY_UPDATED) &&
+        this.isTargetChannelMoreStable_();
   },
 
   /** @private */
   onCheckUpdatesTap_: function() {
     this.onUpdateStatusChanged_({status: UpdateStatus.CHECKING});
     this.browserProxy_.requestUpdate();
   },
 
   /**
    * @return {boolean}
    * @private
    */
   shouldShowCheckUpdates_: function() {
     return !this.hasCheckedForUpdates_ ||
-        this.currentUpdateStatusEvent_.status == UpdateStatus.FAILED;
+        this.checkStatus_(UpdateStatus.FAILED);
   },
 
   /**
    * @return {boolean}
    * @private
    */
   shouldShowRegulatoryInfo_: function() {
     return this.regulatoryInfo_ !== null;
   },
 </if>
 
 <if expr="_google_chrome">
   /** @private */
   onReportIssueTap_: function() {
     this.browserProxy_.openFeedbackDialog();
   },
 </if>
 });