MD Settings: About page, hooking up channel switcher dialog.

chrome/browser/resources/settings/about_page/about_page.html

 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="/about_page/about_page_browser_proxy.html">
 <link rel="import" href="/i18n_setup.html">
 <link rel="import" href="/icons.html">
 <link rel="import" href="/settings_page/main_page_behavior.html">
 <link rel="import" href="/settings_page/settings_animated_pages.html">
 <link rel="import" href="/settings_page/settings_section.html">
 <link rel="import" href="/settings_page_css.html">
 <link rel="import" href="/settings_shared_css.html">
 <link rel="import" href="chrome://resources/cr_elements/icons.html">
@@ skipping 57 matching lines @@
           </div>
           <div class="settings-box two-line">
             <div hidden="[[!shouldShowUpdateStatus_(currentUpdateStatusEvent_)]]">
               <iron-icon
                   icon$="[[getIcon_(currentUpdateStatusEvent_)]]"
                   src="[[getIconSrc_(currentUpdateStatusEvent_)]]">
               </iron-icon>
             </div>
             <div class="start">
               <div hidden="[[!shouldShowUpdateStatus_(currentUpdateStatusEvent_)]]">
-                [[getUpdateStatusMessage_(currentUpdateStatusEvent_)]]
+                [[getUpdateStatusMessage_(currentUpdateStatusEvent_,targetChannel_)]]

[dschuyler, 2016/05/27 22:16:21]

Please wrap line
(and/or add a space after the comma).

[dpapad, 2016/05/27 23:32:17]

Done.

               </div>
               <div class="secondary">$i18n{aboutBrowserVersion}</div>
             </div>
             <paper-button id="relaunch" class="secondary-action"
+<if expr="not chromeos">
                 hidden="[[!shouldShowRelaunch_(currentUpdateStatusEvent_)]]"
+</if>
+<if expr="chromeos">
+                hidden="[[!shouldShowRelaunch_(currentUpdateStatusEvent_,targetChannel_)]]"

[dschuyler, 2016/05/27 22:16:21]

Please wrap line
(and/or add a space after the comma).

[dpapad, 2016/05/27 23:32:17]

Done.

Regarding breaking line: Do we have a rule about 80 columns in HTML? I did not
find any mention at https://google.github.io/styleguide/htmlcssguide.xml.

Personally I find single-line Polymer binding declaration a bit more readable,
especially when the binding is within quotes, mostly because I am not used to
having opening and closing quotes in different lines in HTML.

[dschuyler, 2016/05/28 00:07:43]

It's at 
https://www.chromium.org/developers/web-development-style-guide

We make an exception for <import>. Import lines
can go on past 80 cols as needed.

+</if>
                 on-tap="onRelaunchTap_">
               $i18n{aboutRelaunch}
             </paper-button>
 <if expr="chromeos">
             <paper-button id="relaunchAndPowerwash" class="secondary-action"
-                hidden="[[!shouldShowRelaunchAndPowerwash_(currentUpdateStatusEvent_)]]"
+                hidden="[[!shouldShowRelaunchAndPowerwash_(currentUpdateStatusEvent_,targetChannel_)]]"

[dschuyler, 2016/05/27 22:16:21]

Please wrap line and add a space after the comma.

[dpapad, 2016/05/27 23:32:17]

Done.

                 on-tap="onRelaunchAndPowerwashTap_">
               $i18n{aboutRelaunchAndPowerwash}
             </paper-button>
             <paper-button id="checkForUpdates" class="secondary-action"
                 hidden="[[!shouldShowCheckUpdates_(currentUpdateStatusEvent_)]]"
                 on-tap="onCheckUpdatesTap_">
               $i18n{aboutCheckForUpdates}
             </paper-button>
 </if>
           </div>
@@ skipping 39 matching lines @@
           <settings-subpage page-title="Detailed build information">
             <settings-detailed-build-info></settings-detailed-build-info>
           </settings-subpage>
         </template>
 </if>
       </settings-animated-pages>
     </settings-section>
   </template>
   <script src="about_page.js"></script>
 </dom-module>