Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2011693002: Allow use_debug_fission to be passed to gcc_toolchain(). (Closed)

Created:
4 years, 7 months ago by Dirk Pranke
Modified:
4 years, 7 months ago
Reviewers:
Roland McGrath
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow use_debug_fission to be passed to gcc_toolchain(). This is needed so that the nacl_bootstrap toolchains can force it to be off regardless of the setting for the default toolchains. TBR=mcgrathr@chromium.org BUG=605896 Committed: https://crrev.com/8aefecbfa0b40fb644ca63fd742bd04eb576ba7f Cr-Commit-Position: refs/heads/master@{#395770}

Patch Set 1 : for review/landing #

Patch Set 2 : do not use forward_variables_from() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M build/toolchain/gcc_toolchain.gni View 1 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Dirk Pranke
4 years, 7 months ago (2016-05-24 22:47:27 UTC) #1
Dirk Pranke
4 years, 7 months ago (2016-05-24 22:49:26 UTC) #5
Dirk Pranke
this is needed (must be rolled into NaCl) before we can land https://codereview.chromium.org/2004303005/ .
4 years, 7 months ago (2016-05-24 22:49:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011693002/20001
4 years, 7 months ago (2016-05-24 22:50:24 UTC) #8
Roland McGrath
lgtm
4 years, 7 months ago (2016-05-24 22:52:12 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/142661) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 7 months ago (2016-05-24 22:55:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011693002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011693002/60001
4 years, 7 months ago (2016-05-24 23:42:44 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 7 months ago (2016-05-25 01:44:05 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 01:49:09 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8aefecbfa0b40fb644ca63fd742bd04eb576ba7f
Cr-Commit-Position: refs/heads/master@{#395770}

Powered by Google App Engine
This is Rietveld 408576698