third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp - Issue 2011673002: [DevTools] Add notifyPopupOpeningObservers call before running debug loop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 2011673002: [DevTools] Add notifyPopupOpeningObservers call before running debug loop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

index 0f735f6046d6c9439c8f1294b71bc2eb515587ef..d90ecfcb169e813844ddbe598b0d042196bc3181 100644

--- a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

+++ b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

@@ -196,6 +196,7 @@ private:

m_frozenViews.add(view);

views.append(view);

view->setIgnoreInputEvents(true);

+ view->chromeClient().notifyPopupOpeningObservers();

}

const WebFrameWidgetsSet& widgetImpls = WebFrameWidgetImpl::allInstances();

« no previous file with comments | « third_party/WebKit/Source/web/ChromeClientImpl.h ('k') | third_party/WebKit/Source/web/WebViewImpl.h » ('j') | no next file with comments »