Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: third_party/WebKit/Source/web/ChromeClientImpl.h

Issue 2011673002: [DevTools] Add notifyPopupOpeningObservers call before running debug loop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 181
182 CompositorProxyClient* createCompositorProxyClient(LocalFrame*) override; 182 CompositorProxyClient* createCompositorProxyClient(LocalFrame*) override;
183 FloatSize elasticOverscroll() const override; 183 FloatSize elasticOverscroll() const override;
184 184
185 void didObserveNonGetFetchFromScript() const override; 185 void didObserveNonGetFetchFromScript() const override;
186 186
187 PassOwnPtr<WebFrameScheduler> createFrameScheduler(BlameContext*) override; 187 PassOwnPtr<WebFrameScheduler> createFrameScheduler(BlameContext*) override;
188 188
189 double lastFrameTimeMonotonic() const override; 189 double lastFrameTimeMonotonic() const override;
190 190
191 void notifyPopupOpeningObservers() const;
192
191 private: 193 private:
192 explicit ChromeClientImpl(WebViewImpl*); 194 explicit ChromeClientImpl(WebViewImpl*);
193 195
194 bool isChromeClientImpl() const override { return true; } 196 bool isChromeClientImpl() const override { return true; }
195 void registerPopupOpeningObserver(PopupOpeningObserver*) override; 197 void registerPopupOpeningObserver(PopupOpeningObserver*) override;
196 void unregisterPopupOpeningObserver(PopupOpeningObserver*) override; 198 void unregisterPopupOpeningObserver(PopupOpeningObserver*) override;
197 199
198 void notifyPopupOpeningObservers() const;
199 void setCursor(const WebCursorInfo&, LocalFrame* localRoot); 200 void setCursor(const WebCursorInfo&, LocalFrame* localRoot);
200 201
201 WebViewImpl* m_webView; // Weak pointer. 202 WebViewImpl* m_webView; // Weak pointer.
202 WindowFeatures m_windowFeatures; 203 WindowFeatures m_windowFeatures;
203 Vector<PopupOpeningObserver*> m_popupOpeningObservers; 204 Vector<PopupOpeningObserver*> m_popupOpeningObservers;
204 Cursor m_lastSetMouseCursorForTesting; 205 Cursor m_lastSetMouseCursorForTesting;
205 bool m_cursorOverridden; 206 bool m_cursorOverridden;
206 bool m_didRequestNonEmptyToolTip; 207 bool m_didRequestNonEmptyToolTip;
207 }; 208 };
208 209
209 DEFINE_TYPE_CASTS(ChromeClientImpl, ChromeClient, client, client->isChromeClient Impl(), client.isChromeClientImpl()); 210 DEFINE_TYPE_CASTS(ChromeClientImpl, ChromeClient, client, client->isChromeClient Impl(), client.isChromeClientImpl());
210 211
211 } // namespace blink 212 } // namespace blink
212 213
213 #endif 214 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698