Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2011643002: [remoting host] Fix the APT repository setup in the Debian package. (Closed)

Created:
4 years, 7 months ago by Lambros
Modified:
4 years, 7 months ago
Reviewers:
Michael Moss, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[remoting host] Fix the APT repository setup in the Debian package. This adds the [arch=] qualifier to the APT sources.list entry for Chrome Remote Desktop, so that APT no longer reports an error for the missing 32-bit package. This also corrects a regex used for detecting the current configuration. BUG=604469 Committed: https://crrev.com/20447ead8ba4b9bf3310da0d80a23a199aba1d60 Cr-Commit-Position: refs/heads/master@{#395748}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M remoting/host/installer/linux/build-deb.sh View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Lambros
mmoss: PTAL jamiewalch: OWNERS @mmoss: I'm not sure how to properly test that the regex ...
4 years, 7 months ago (2016-05-24 21:25:32 UTC) #2
Michael Moss
On 2016/05/24 21:25:32, Lambros wrote: > mmoss: PTAL > jamiewalch: OWNERS > > @mmoss: I'm ...
4 years, 7 months ago (2016-05-24 22:00:27 UTC) #3
Jamie
Rubber-stamp LGTM.
4 years, 7 months ago (2016-05-24 22:56:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011643002/1
4 years, 7 months ago (2016-05-24 23:00:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 00:21:02 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 00:24:15 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20447ead8ba4b9bf3310da0d80a23a199aba1d60
Cr-Commit-Position: refs/heads/master@{#395748}

Powered by Google App Engine
This is Rietveld 408576698