Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1312)

Issue 2011623002: Cherry-picking hangouts.google.com whitelisting change into M52. (Closed)

Created:
4 years, 7 months ago by AlexZ
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez, qaz-chromium, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Cherry-picking hangouts.google.com whitelisting change into M52. Urgent: whitelist hangouts.google.com further (should've been done in issue 1552383002 from Dec 2015, but...) to allow video effects plugin access; tag on meet.google.com for a similar purpose; tax: refactor whitelist checks into separate thing. R=sky@chromium.org,tsepez@chromium.org BUG=614062 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/1974413003 Cr-Commit-Position: refs/heads/master@{#395172} (cherry picked from commit 81dcbd6123178d58c5edc53d1453e03f9afa31ca)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -123 lines) Patch
M chrome/chrome_renderer.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/OWNERS View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/renderer/app_categorizer.h View 1 chunk +16 lines, -0 lines 0 comments Download
A chrome/renderer/app_categorizer.cc View 1 chunk +80 lines, -0 lines 0 comments Download
A chrome/renderer/app_categorizer_unittest.cc View 1 chunk +125 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 4 chunks +10 lines, -53 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client_unittest.cc View 6 chunks +23 lines, -70 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
qaz-chromium
Manually cherry-picking... Thanks.
4 years, 7 months ago (2016-05-24 20:37:14 UTC) #2
sky
Why aren't you using drover?
4 years, 7 months ago (2016-05-24 20:57:01 UTC) #3
qaz-chromium
On 2016/05/24 20:57:01, sky wrote: > Why aren't you using drover? I did, but got ...
4 years, 7 months ago (2016-05-24 21:16:22 UTC) #4
sky
Got it, LGTM
4 years, 7 months ago (2016-05-24 21:36:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011623002/1
4 years, 7 months ago (2016-05-24 21:49:54 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 21:51:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698