Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 2011573002: PPC: Collect call counts for constructor calls, too. (Closed)

Created:
4 years, 7 months ago by JaideepBajwa
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Collect call counts for constructor calls, too. Port a6ddbef0645a944fc3d46d89af6362d585170348 Original commit message: The TurboFan inliner makes use of these counts. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/541a8380b59cf6219fce45936c2adbe74fe9fd2d Cr-Commit-Position: refs/heads/master@{#36490}

Patch Set 1 #

Total comments: 1

Patch Set 2 : added offset to load/store instr and removed the add instr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M src/ppc/code-stubs-ppc.cc View 1 4 chunks +25 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
JaideepBajwa
PTAL
4 years, 7 months ago (2016-05-24 18:33:10 UTC) #1
MTBrandyberry
lgtm, with one comment. https://codereview.chromium.org/2011573002/diff/1/src/ppc/code-stubs-ppc.cc File src/ppc/code-stubs-ppc.cc (right): https://codereview.chromium.org/2011573002/diff/1/src/ppc/code-stubs-ppc.cc#newcode1949 src/ppc/code-stubs-ppc.cc:1949: __ addi(r8, r8, Operand(count_offset)); It ...
4 years, 7 months ago (2016-05-24 19:01:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011573002/20001
4 years, 7 months ago (2016-05-24 19:36:54 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-24 20:07:31 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 20:09:02 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/541a8380b59cf6219fce45936c2adbe74fe9fd2d
Cr-Commit-Position: refs/heads/master@{#36490}

Powered by Google App Engine
This is Rietveld 408576698